From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E92A2C433F5 for ; Wed, 25 May 2022 10:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232946AbiEYKlx (ORCPT ); Wed, 25 May 2022 06:41:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbiEYKlw (ORCPT ); Wed, 25 May 2022 06:41:52 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B92C986E7; Wed, 25 May 2022 03:41:51 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 2683B1F448AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1653475310; bh=xXH5hN96WvbdMWEtdR67xyJ1Nu1XNE5YBoILGq7ZbpQ=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=GPVM261LD27yCOCRgYPXMlzrkHAEPhQ89rHcxGYniANEaVsJsymLMyx1CwnD76jpo DKUEjtN2qnR1ESBC9BhZ91Cz3avwwyzhdQOKDeGAN4ErtgF4V+kDIVXQ509uW/hWRT 0xQOmuokQ8lvqgdR4sbjbkYIZ8Cu5dSj3RiGucUWNhQsjZ7fApWtBR45VVX974yrkO B198tAeJ+Bi6SVYt0liqgvPrEnbkDwhSSA0CytvrGumQjHCVw9Wwn1rMA6IW28wSr3 vD9MSPkDBGuwCPyg6z0PbGGA9aMIGw4IP34+jTqIjCM2bphQ1dFtp6er0RXBtnZCy9 Kfk2xShk+Gj8Q== Message-ID: Date: Wed, 25 May 2022 12:41:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v7 1/1] firmware: mediatek: add adsp ipc protocol interface Content-Language: en-US From: AngeloGioacchino Del Regno To: Allen-KH Cheng , Matthias Brugger , Mark Brown Cc: Kevin Hilman , Linux-ALSA , tzungbi@google.com, Chen-Yu Tsai , cujomalainey@google.com, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Jaroslav Kysela , Takashi Iwai , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sound-open-firmware@alsa-project.org References: <20220407130338.28939-1-allen-kh.cheng@mediatek.com> <20220407130338.28939-2-allen-kh.cheng@mediatek.com> <54d6c0ff-d93c-0506-4db9-3852c69211ab@collabora.com> In-Reply-To: <54d6c0ff-d93c-0506-4db9-3852c69211ab@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 25/05/22 12:39, AngeloGioacchino Del Regno ha scritto: > Il 07/04/22 15:03, Allen-KH Cheng ha scritto: >> From: Allen-KH Cheng >> >> Some of mediatek processors contain >> the Tensilica HiFix DSP for audio processing. >> >> The communication between Host CPU and DSP firmware is >> taking place using a shared memory area for message passing. >> >> ADSP IPC protocol offers (send/recv) interfaces using >> mediatek-mailbox APIs. >> >> We use two mbox channels to implement a request-reply protocol. >> >> Signed-off-by: Allen-KH Cheng >> Reviewed-by: Pierre-Louis Bossart >> Reviewed-by: Curtis Malainey >> Reviewed-by: Tzung-Bi Shih >> Reviewed-by: YC Hung >> Reviewed-by: AngeloGioacchino Del Regno >> --- >>   drivers/firmware/Kconfig                      |   1 + >>   drivers/firmware/Makefile                     |   1 + >>   drivers/firmware/mediatek/Kconfig             |   9 + >>   drivers/firmware/mediatek/Makefile            |   2 + >>   drivers/firmware/mediatek/mtk-adsp-ipc.c      | 161 ++++++++++++++++++ >>   .../linux/firmware/mediatek/mtk-adsp-ipc.h    |  65 +++++++ >>   6 files changed, 239 insertions(+) >>   create mode 100644 drivers/firmware/mediatek/Kconfig >>   create mode 100644 drivers/firmware/mediatek/Makefile >>   create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c >>   create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h >> > > Gentle ping for this one, as it's getting stale... and it's ready. > > To add context, this driver is *really* necessary, as support for it > is added in the MT8195 ASoC SOF driver as a platform device [1], and the > necessary memory regions are coming from the mediatek,mt8195-dsp [2] driver. > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/sound/soc/sof/mediatek/mt8195/mt8195.c?h=next-20220525#n389 > > > [2]: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml?h=next-20220525#n61 > > > Cheers, > Angelo I'm sorry, ignore me, another version of this one was already merged.