From: <Tudor.Ambarus@microchip.com>
To: <krzysztof.kozlowski@canonical.com>, <p.yadav@ti.com>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<robh+dt@kernel.org>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<atish.patra@wdc.com>, <sagar.kadam@sifive.com>,
<linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 1/5] dt-bindings: mtd: jedec,spi-nor: document issi,is25wp256
Date: Fri, 20 Aug 2021 13:28:48 +0000 [thread overview]
Message-ID: <ae4c58fe-0af5-3f1d-cc16-27b78772cbb5@microchip.com> (raw)
In-Reply-To: <5bff5a0c-48e5-3721-5595-836ce0562c6f@canonical.com>
On 8/19/21 8:36 PM, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 19/08/2021 19:28, Pratyush Yadav wrote:
>> + Tudor (you should be listed as a maintainer for this file IMO)
>>
>> On 19/08/21 06:59PM, Krzysztof Kozlowski wrote:
>>> Document bindings for the issi,is25wp256 SPI NOR flash.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> ---
>>> Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> index ed590d7c6e37..0db64ac7dc33 100644
>>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> @@ -33,6 +33,7 @@ properties:
>>> - items:
>>> - enum:
>>> - issi,is25lp016d
>>> + - issi,is25wp256
>>
>> I don't think we want to add any new flash specific compatibles. Why is
>> "jedec,spi-nor" not enough for you?
>
> It's fine for me. I had impression that specific compatibles are still
> preferred and one of boards is using this one. The other way is to
> remove this compatible from the board DTS.
>
Pratyush is right, we prefer to bind just to the generic "jedec,spi-nor"
compatible whenever possible.
Cheers,
ta
next prev parent reply other threads:[~2021-08-20 13:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 16:59 [PATCH 1/5] dt-bindings: mtd: jedec,spi-nor: document issi,is25wp256 Krzysztof Kozlowski
2021-08-19 16:59 ` [PATCH 2/5] riscv: dts: sifive: fix Unleashed board compatible Krzysztof Kozlowski
2021-08-19 16:59 ` [PATCH 3/5] riscv: dts: sifive: drop duplicated nodes and properties in sifive Krzysztof Kozlowski
2021-08-19 16:59 ` [PATCH 4/5] riscv: dts: microchip: add missing compatibles for clint and plic Krzysztof Kozlowski
2021-08-19 16:59 ` [PATCH 5/5] riscv: dts: sifive: add missing compatible for plic Krzysztof Kozlowski
2021-08-19 17:28 ` [PATCH 1/5] dt-bindings: mtd: jedec,spi-nor: document issi,is25wp256 Pratyush Yadav
2021-08-19 17:36 ` Krzysztof Kozlowski
2021-08-20 13:28 ` Tudor.Ambarus [this message]
2021-08-25 12:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae4c58fe-0af5-3f1d-cc16-27b78772cbb5@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sagar.kadam@sifive.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).