From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BDD744C61; Tue, 10 Sep 2024 15:52:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725983560; cv=none; b=tfoI2E6XYGV/uhVlRu4tOPw4D4NmfOZeuHNqOySMxK9Ye4WB5L6D1bEwkZzTNxkU4ft0xx6XpCiWkZdXfNfvEdisUaBVovul2JDgvGHYpyKnREVCCUcJ8ZX6tevcF5LBkRe6+o0lq2A77w00tTKdS4IcPE4QrLKS0Weum8sQ/DI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725983560; c=relaxed/simple; bh=VqVYu4N/Tf1UtM3sawFVKjYsdrOcwFFbjlE2c3Q5n6o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UvS4YSlvdzQ3iQNoq0Y6xA+cchOL5UcpAkk4RL5rDgQRklAt1X9sHKhfsntilr6HHrvw60P1her2dDdF6AyOephS3U/qDlfqIMyZPNbPv2AYEo7SQCh7HRbpHzX7sivef+Lsu4RXBwg/sbipOytpFsMI15wqoDOywyt0xPPyy+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=eQguQaDh; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="eQguQaDh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1725983557; bh=VqVYu4N/Tf1UtM3sawFVKjYsdrOcwFFbjlE2c3Q5n6o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eQguQaDhVq678MgrPKfPcNoIMM+tkkuOFHGC4Nfix43E7Oqd4JTJqZUW3043HaUQG brN2zMOxEQ3YE8qsp8XT8qjaxfA0cPPhVj8mE+aPqHARpYIhuBv95ZYVNOJeN9JTIK 8rxZ1EjcGMV0Ui7aHnw6oltLy99/yrWBpYKKvue3LZ9cTlX4TGsN0iS6ab8lG4xB+a 45uzTdAnunuUvTjqO+unl/H+VH802SJaVkurGGZ2oB/abHUN2tctLqmN6tBxbkEzGT aCxBdWj+tSvxBaN3Dtj74F7fRp23DVaapGtixCj6b9zk7xbvOrmcLlm4QeLSmOuwHh TcOWGrZ9IzLsA== Received: from [192.168.1.90] (unknown [188.27.55.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3B9FA17E12D3; Tue, 10 Sep 2024 17:52:36 +0200 (CEST) Message-ID: Date: Tue, 10 Sep 2024 18:52:35 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library To: Markus Elfring , Algea Cao , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, Andrzej Hajda , Andy Yan , Conor Dooley , Daniel Vetter , David Airlie , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Maarten Lankhorst , Mark Yao , Maxime Ripard , Neil Armstrong , Rob Herring , Robert Foss , Sandy Huang , Sascha Hauer , Thomas Zimmermann Cc: LKML , Alexandre Arnoud , Luis de Arquer References: <20240831-b4-rk3588-bridge-upstream-v5-2-9503bece0136@collabora.com> From: Cristian Ciocaltea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 9/8/24 12:11 PM, Markus Elfring wrote: > … >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c >> @@ -0,0 +1,708 @@ > … >> +static int dw_hdmi_qp_i2c_xfer(struct i2c_adapter *adap, >> + struct i2c_msg *msgs, int num) >> +{ > … >> + mutex_lock(&i2c->lock); > … >> + dw_hdmi_qp_mod(hdmi, 0, I2CM_OP_DONE_MASK_N | I2CM_NACK_RCVD_MASK_N, >> + MAINUNIT_1_INT_MASK_N); >> + >> + mutex_unlock(&i2c->lock); >> + >> + return ret; >> +} > … > > Under which circumstances would you become interested to apply a statement > like “guard(mutex)(&i2c->lock);”? > https://elixir.bootlin.com/linux/v6.11-rc6/source/include/linux/mutex.h#L196 Applied for the upcoming v7. Thanks, Cristian