[PATCH v3 0/4] MIPS: dts: ralink: mt7628a: Tweak for GARDENA smart Gateway

[PATCH v3 0/4] MIPS: dts: ralink: mt7628a: Tweak for GARDENA smart Gateway

[Ezra Buehler]

From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>

Various devicetree changes needed for the MT7688-based GARDENA smart
Gateway.

Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
---
Changes in v3:
- Remove duplicate entries in mediatek,mtmips-sysc DT binding
- Link to v2: https://lore.kernel.org/20250617103058.1125836-1-ezra@easyb.ch

Changes in v2:
- Add patch for mediatek,mtmips-sysc DT binding
- Add Reviewed-by tags
- Link to v1: https://lore.kernel.org/20250611194716.302126-1-ezra@easyb.ch

---
Ezra Buehler (4):
  dt-bindings: clock: mediatek,mtmips-sysc: Adapt compatible for MT7688
    boards
  MIPS: dts: ralink: mt7628a: Fix sysc's compatible property for MT7688
  MIPS: dts: ralink: mt7628a: Update watchdog node according to bindings
  MIPS: dts: ralink: gardena_smart_gateway_mt7688: Fix power LED

 .../bindings/clock/mediatek,mtmips-sysc.yaml  | 27 ++++++++++---------
 .../ralink/gardena_smart_gateway_mt7688.dts   |  2 +-
 arch/mips/boot/dts/ralink/mt7628a.dtsi        | 11 +++-----
 3 files changed, 19 insertions(+), 21 deletions(-)

--
2.43.0

[PATCH v3 1/4] dt-bindings: clock: mediatek,mtmips-sysc: Adapt compatible for MT7688 boards

[Ezra Buehler]

From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>

As the MT7628 and MT7688 are identical in most respects, mt7628a.dtsi is
used for both SoCs. To prevent "Kernel panic - not syncing: unable to
get CPU clock, err=-2" and allow an MT7688-based board to boot, the
following must be allowed:

    compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";

Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
---
 .../bindings/clock/mediatek,mtmips-sysc.yaml  | 27 ++++++++++---------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
index 83c1803ffd16..3fabaa8acc10 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
@@ -26,18 +26,21 @@ description: |
 
 properties:
   compatible:
-    items:
-      - enum:
-          - ralink,mt7620-sysc
-          - ralink,mt7628-sysc
-          - ralink,mt7688-sysc
-          - ralink,rt2880-sysc
-          - ralink,rt3050-sysc
-          - ralink,rt3052-sysc
-          - ralink,rt3352-sysc
-          - ralink,rt3883-sysc
-          - ralink,rt5350-sysc
-      - const: syscon
+    oneOf:
+      - items:
+          - enum:
+              - ralink,mt7620-sysc
+              - ralink,rt2880-sysc
+              - ralink,rt3050-sysc
+              - ralink,rt3052-sysc
+              - ralink,rt3352-sysc
+              - ralink,rt3883-sysc
+              - ralink,rt5350-sysc
+          - const: syscon
+      - items:
+          - const: ralink,mt7628-sysc
+          - const: ralink,mt7688-sysc
+          - const: syscon
 
   reg:
     maxItems: 1
-- 
2.43.0

[PATCH v3 2/4] MIPS: dts: ralink: mt7628a: Fix sysc's compatible property for MT7688

[Ezra Buehler]

From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>

Otherwise, the MT7688-based GARDENA smart Gateway will fail to boot
printing "Kernel panic - not syncing: unable to get CPU clock, err=-2".

Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
Reviewed-by: Stefan Roese <sr@denx.de>
---
 arch/mips/boot/dts/ralink/mt7628a.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/ralink/mt7628a.dtsi b/arch/mips/boot/dts/ralink/mt7628a.dtsi
index 0212700c4fb4..10221a41f02a 100644
--- a/arch/mips/boot/dts/ralink/mt7628a.dtsi
+++ b/arch/mips/boot/dts/ralink/mt7628a.dtsi
@@ -33,7 +33,7 @@ palmbus@10000000 {
 		#size-cells = <1>;
 
 		sysc: syscon@0 {
-			compatible = "ralink,mt7628-sysc", "syscon";
+			compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
 			reg = <0x0 0x60>;
 			#clock-cells = <1>;
 			#reset-cells = <1>;
-- 
2.43.0

[PATCH v3 3/4] MIPS: dts: ralink: mt7628a: Update watchdog node according to bindings

[Ezra Buehler]

From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>

Most notably, add the mediatek,sysctl phandle and remove the redundant
reset/interrupt-related properties from the watchdog node. This is in
line with the corresponding devicetree (mt7628an.dtsi) used by the
OpenWrt project.

This has been tested on the MT7688-based GARDENA smart Gateway.

Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 arch/mips/boot/dts/ralink/mt7628a.dtsi | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/arch/mips/boot/dts/ralink/mt7628a.dtsi b/arch/mips/boot/dts/ralink/mt7628a.dtsi
index 10221a41f02a..5d7a6cfa9e2b 100644
--- a/arch/mips/boot/dts/ralink/mt7628a.dtsi
+++ b/arch/mips/boot/dts/ralink/mt7628a.dtsi
@@ -134,13 +134,8 @@ pinmux_p4led_an_gpio: p4led-an-gpio-pins {
 
 		watchdog: watchdog@100 {
 			compatible = "mediatek,mt7621-wdt";
-			reg = <0x100 0x30>;
-
-			resets = <&sysc 8>;
-			reset-names = "wdt";
-
-			interrupt-parent = <&intc>;
-			interrupts = <24>;
+			reg = <0x100 0x100>;
+			mediatek,sysctl = <&sysc>;
 
 			status = "disabled";
 		};
-- 
2.43.0

[PATCH v3 4/4] MIPS: dts: ralink: gardena_smart_gateway_mt7688: Fix power LED

[Ezra Buehler]

From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>

When starting up, the GARDENA smart Gateway's power LED should be
flashing green. It is unclear why it was initially set to "off".

The LED frequency cannot be configured in the devicetree. Luckily, the
default is 1 Hz, which is what we want.

Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts b/arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts
index 7743d014631a..0bfb1dde9764 100644
--- a/arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts
+++ b/arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts
@@ -56,7 +56,7 @@ led-power-blue {
 		led-power-green {
 			label = "smartgw:power:green";
 			gpios = <&gpio 19 GPIO_ACTIVE_HIGH>;
-			default-state = "off";
+			linux,default-trigger = "timer";
 		};
 
 		led-power-red {
-- 
2.43.0

Re: [PATCH v3 1/4] dt-bindings: clock: mediatek,mtmips-sysc: Adapt compatible for MT7688 boards

[Krzysztof Kozlowski]

On Thu, Jun 19, 2025 at 10:34:59PM GMT, Ezra Buehler wrote:
> From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
> 
> As the MT7628 and MT7688 are identical in most respects, mt7628a.dtsi is
> used for both SoCs. To prevent "Kernel panic - not syncing: unable to
> get CPU clock, err=-2" and allow an MT7688-based board to boot, the
> following must be allowed:
> 
>     compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
> 
> Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
> ---
>  .../bindings/clock/mediatek,mtmips-sysc.yaml  | 27 ++++++++++---------
>  1 file changed, 15 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
> index 83c1803ffd16..3fabaa8acc10 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
> @@ -26,18 +26,21 @@ description: |
>  
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - ralink,mt7620-sysc
> -          - ralink,mt7628-sysc
> -          - ralink,mt7688-sysc

I do not understand why this is removed and commit msg explains nothing
about it. Re-add it back.

Best regards,
Krzysztof

Re: [PATCH v3 1/4] dt-bindings: clock: mediatek,mtmips-sysc: Adapt compatible for MT7688 boards

[Ezra Buehler]

> On 20 Jun 2025, at 09:42, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
> On Thu, Jun 19, 2025 at 10:34:59PM GMT, Ezra Buehler wrote:
>> From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>> 
>> As the MT7628 and MT7688 are identical in most respects, mt7628a.dtsi is
>> used for both SoCs. To prevent "Kernel panic - not syncing: unable to
>> get CPU clock, err=-2" and allow an MT7688-based board to boot, the
>> following must be allowed:
>> 
>>    compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
>> 
>> Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>> ---
>> .../bindings/clock/mediatek,mtmips-sysc.yaml  | 27 ++++++++++---------
>> 1 file changed, 15 insertions(+), 12 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>> index 83c1803ffd16..3fabaa8acc10 100644
>> --- a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>> @@ -26,18 +26,21 @@ description: |
>> 
>> properties:
>>   compatible:
>> -    items:
>> -      - enum:
>> -          - ralink,mt7620-sysc
>> -          - ralink,mt7628-sysc
>> -          - ralink,mt7688-sysc
> 
> I do not understand why this is removed and commit msg explains nothing
> about it. Re-add it back.

OK, so you suggest we allow

compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";

and

compatible = "ralink,mt7688-sysc", "syscon";

I'll adapt my patch accordingly.

Still, as AFAIK the MT7628 and MT7688 are identical in this regard,

compatible = "ralink,mt7688-sysc", "ralink,mt7628-sysc", "syscon";

would technically be valid too. Could you elaborate why that is not a
good idea? The MT7688 is basically a subset of the MT7628.

Cheers,
Ezra.

Re: [PATCH v3 1/4] dt-bindings: clock: mediatek,mtmips-sysc: Adapt compatible for MT7688 boards

[Krzysztof Kozlowski]

On 24/06/2025 11:08, Ezra Buehler wrote:
>> On 20 Jun 2025, at 09:42, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Thu, Jun 19, 2025 at 10:34:59PM GMT, Ezra Buehler wrote:
>>> From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>>>
>>> As the MT7628 and MT7688 are identical in most respects, mt7628a.dtsi is
>>> used for both SoCs. To prevent "Kernel panic - not syncing: unable to
>>> get CPU clock, err=-2" and allow an MT7688-based board to boot, the
>>> following must be allowed:
>>>
>>>    compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
>>>
>>> Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>>> ---
>>> .../bindings/clock/mediatek,mtmips-sysc.yaml  | 27 ++++++++++---------
>>> 1 file changed, 15 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>> index 83c1803ffd16..3fabaa8acc10 100644
>>> --- a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>> +++ b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>> @@ -26,18 +26,21 @@ description: |
>>>
>>> properties:
>>>   compatible:
>>> -    items:
>>> -      - enum:
>>> -          - ralink,mt7620-sysc
>>> -          - ralink,mt7628-sysc
>>> -          - ralink,mt7688-sysc
>>
>> I do not understand why this is removed and commit msg explains nothing
>> about it. Re-add it back.
> 
> OK, so you suggest we allow
> 
> compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
> 
> and
> 
> compatible = "ralink,mt7688-sysc", "syscon";
> 
> I'll adapt my patch accordingly.
> 
> Still, as AFAIK the MT7628 and MT7688 are identical in this regard,

Standard rules apply expressed in writing bindings, some talks/guides
and all modern SoCs...


> 
> compatible = "ralink,mt7688-sysc", "ralink,mt7628-sysc", "syscon";
> 
> would technically be valid too. Could you elaborate why that is not a
> good idea? The MT7688 is basically a subset of the MT7628.

You did not send such patch.

Best regards,
Krzysztof

Re: [PATCH v3 1/4] dt-bindings: clock: mediatek,mtmips-sysc: Adapt compatible for MT7688 boards

[Ezra Buehler]

> On 24 Jun 2025, at 11:12, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
> On 24/06/2025 11:08, Ezra Buehler wrote:
>>> On 20 Jun 2025, at 09:42, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> 
>>> On Thu, Jun 19, 2025 at 10:34:59PM GMT, Ezra Buehler wrote:
>>>> From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>>>> 
>>>> As the MT7628 and MT7688 are identical in most respects, mt7628a.dtsi is
>>>> used for both SoCs. To prevent "Kernel panic - not syncing: unable to
>>>> get CPU clock, err=-2" and allow an MT7688-based board to boot, the
>>>> following must be allowed:
>>>> 
>>>>   compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
>>>> 
>>>> Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>>>> ---
>>>> .../bindings/clock/mediatek,mtmips-sysc.yaml  | 27 ++++++++++---------
>>>> 1 file changed, 15 insertions(+), 12 deletions(-)
>>>> 
>>>> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>>> index 83c1803ffd16..3fabaa8acc10 100644
>>>> --- a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>>> +++ b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>>> @@ -26,18 +26,21 @@ description: |
>>>> 
>>>> properties:
>>>>  compatible:
>>>> -    items:
>>>> -      - enum:
>>>> -          - ralink,mt7620-sysc
>>>> -          - ralink,mt7628-sysc
>>>> -          - ralink,mt7688-sysc
>>> 
>>> I do not understand why this is removed and commit msg explains nothing
>>> about it. Re-add it back.
>> 
>> OK, so you suggest we allow
>> 
>> compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
>> 
>> and
>> 
>> compatible = "ralink,mt7688-sysc", "syscon";
>> 
>> I'll adapt my patch accordingly.
>> 
>> Still, as AFAIK the MT7628 and MT7688 are identical in this regard,
> 
> Standard rules apply expressed in writing bindings, some talks/guides
> and all modern SoCs...
> 
> 
>> 
>> compatible = "ralink,mt7688-sysc", "ralink,mt7628-sysc", "syscon";
>> 
>> would technically be valid too. Could you elaborate why that is not a
>> good idea? The MT7688 is basically a subset of the MT7628.
> 
> You did not send such patch.

No, I did not. I am just trying to understand the topic better. Anyway,
never mind, I will just do it as you suggested.

Cheers,
Ezra.

Re: [PATCH v3 1/4] dt-bindings: clock: mediatek,mtmips-sysc: Adapt compatible for MT7688 boards

[Krzysztof Kozlowski]

On 24/06/2025 11:21, Ezra Buehler wrote:
>> On 24 Jun 2025, at 11:12, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 24/06/2025 11:08, Ezra Buehler wrote:
>>>> On 20 Jun 2025, at 09:42, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>>
>>>> On Thu, Jun 19, 2025 at 10:34:59PM GMT, Ezra Buehler wrote:
>>>>> From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>>>>>
>>>>> As the MT7628 and MT7688 are identical in most respects, mt7628a.dtsi is
>>>>> used for both SoCs. To prevent "Kernel panic - not syncing: unable to
>>>>> get CPU clock, err=-2" and allow an MT7688-based board to boot, the
>>>>> following must be allowed:
>>>>>
>>>>>   compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
>>>>>
>>>>> Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>>>>> ---
>>>>> .../bindings/clock/mediatek,mtmips-sysc.yaml  | 27 ++++++++++---------
>>>>> 1 file changed, 15 insertions(+), 12 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>>>> index 83c1803ffd16..3fabaa8acc10 100644
>>>>> --- a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>>>> +++ b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>>>> @@ -26,18 +26,21 @@ description: |
>>>>>
>>>>> properties:
>>>>>  compatible:
>>>>> -    items:
>>>>> -      - enum:
>>>>> -          - ralink,mt7620-sysc
>>>>> -          - ralink,mt7628-sysc
>>>>> -          - ralink,mt7688-sysc
>>>>
>>>> I do not understand why this is removed and commit msg explains nothing
>>>> about it. Re-add it back.
>>>
>>> OK, so you suggest we allow
>>>
>>> compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
>>>
>>> and
>>>
>>> compatible = "ralink,mt7688-sysc", "syscon";
>>>
>>> I'll adapt my patch accordingly.
>>>
>>> Still, as AFAIK the MT7628 and MT7688 are identical in this regard,
>>
>> Standard rules apply expressed in writing bindings, some talks/guides
>> and all modern SoCs...
>>
>>
>>>
>>> compatible = "ralink,mt7688-sysc", "ralink,mt7628-sysc", "syscon";
>>>
>>> would technically be valid too. Could you elaborate why that is not a
>>> good idea? The MT7688 is basically a subset of the MT7628.
>>
>> You did not send such patch.
> 
> No, I did not. I am just trying to understand the topic better. Anyway,
> never mind, I will just do it as you suggested.


I cannot give you answer on hypothetical patch without seeing that
patch. Maybe you change or break the ABI? Maybe you affect users? Dunno.
I prefer to discuss the code, not scenarios.


Best regards,
Krzysztof