From: Brian Kim <brian.kim@hardkernel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
"Łukasz Majewski" <l.majewski@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux.amoon@gmail.com,
linux-kernel@vger.kernel.org,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
robh+dt@kernel.org, kgene@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4
Date: Mon, 6 Mar 2017 18:49:43 +0900 [thread overview]
Message-ID: <ae78c84d-796b-609b-ba00-c253a1f63a84@hardkernel.com> (raw)
In-Reply-To: <CAJKOXPcwzy_hAMLoUNcJxYHjHfUF+YmeqSLPy2spvyCwck=TaA@mail.gmail.com>
On 2017년 03월 06일 16:24, Krzysztof Kozlowski wrote:
> On Mon, Mar 6, 2017 at 4:52 AM, Brian Kim <brian.kim@hardkernel.com> wrote:
>> The power button on Odroid XU3/4 is connected with the PWRON pin of
>> s2mps11 PMIC. The s2mps11 sends low signal to GPIO input in exynos 5422
>> via ONOB pin.
>>
>> This patch adds devicetree bindings for the power button of Odroid
>> XU3/4.
>>
>> Signed-off-by: Brian Kim <brian.kim@hardkernel.com>
>> ---
>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
> Hi,
>
> Thanks for the patch.
>
> You sent almost the same patch as Anand did some time ago (with few
> missing things) :
> https://patchwork.kernel.org/patch/8388491/
I'm sorry, Krzysztof. I haven't seen it before.
When I checked git log history in the kernel source, this patch was missed.
So, I submitted it.
>
> All previous comments apply, including that you added a key for gpx0-3
> which is not a PWRON and it does not match description at all.
Yes, gpx0-3 is not PWRON.
PWRON is the 5V power input signal generated by the SW2 push button on Odroid-Xu3/4 boards
(active high). PWRON notifies "power up event to start" to s2mps13 PMIC.
gpx0-3 in Exynos 5422 is connected to the ONOB pin of PMIC.
According to s2mps13 datasheet, ONOB operates as 'PWRON key active low signal'.
s2mps13 PMIC generates the opposite signal from the PWRON via ONOB (active low).
So, we can get the state of power button by gpx0-3.
>
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-03-06 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 2:52 [PATCH] ARM: dts: exynos: Add power button for Odroid XU3/4 Brian Kim
2017-03-06 7:24 ` Krzysztof Kozlowski
2017-03-06 9:49 ` Brian Kim [this message]
2017-03-07 21:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae78c84d-796b-609b-ba00-c253a1f63a84@hardkernel.com \
--to=brian.kim@hardkernel.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).