devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Archit Taneja <architt@codeaurora.org>
To: Andy Gross <andy.gross@linaro.org>, linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] ARM: dts: qcom-apq8064: Fix dsi and hdmi phy cells
Date: Fri, 18 Aug 2017 09:51:04 +0530	[thread overview]
Message-ID: <ae7f9349-9600-5798-2485-bffa54458b34@codeaurora.org> (raw)
In-Reply-To: <1502857706-18379-1-git-send-email-andy.gross@linaro.org>



On 08/16/2017 09:58 AM, Andy Gross wrote:
> This patch adds the necessary #phy-cells property to the DSI and HDMI
> phys.
The DSI and HDMI drivers don't use the common PHY framework, so we end up
being okay without #phy-cells. But we do follow the PHY DT bindings, so it's
necessary in that sense.

Reviewed-by: Archit Taneja <architt@codeaurora.org>

> 
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
> ---
>   arch/arm/boot/dts/qcom-apq8064.dtsi | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index f3db185..d08f3db 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -906,11 +906,11 @@
>   				usb_hs1_phy: phy {
>   					compatible = "qcom,usb-hs-phy-apq8064",
>   						     "qcom,usb-hs-phy";
> -					#phy-cells = <0>;
>   					clocks = <&sleep_clk>, <&cxo_board>;
>   					clock-names = "sleep", "ref";
>   					resets = <&usb1 0>;
>   					reset-names = "por";
> +					#phy-cells = <0>;
>   				};
>   			};
>   		};
> @@ -1263,6 +1263,7 @@
>   		dsi0_phy: dsi-phy@4700200 {
>   			compatible = "qcom,dsi-phy-28nm-8960";
>   			#clock-cells = <1>;
> +			#phy-cells = <0>;
>   
>   			reg = <0x04700200 0x100>,
>   				<0x04700300 0x200>,
> @@ -1417,6 +1418,7 @@
>   
>   			clocks = <&mmcc HDMI_S_AHB_CLK>;
>   			clock-names = "slave_iface_clk";
> +			#phy-cells = <0>;
>   		};
>   
>   		mdp: mdp@5100000 {
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

      reply	other threads:[~2017-08-18  4:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16  4:28 [PATCH] ARM: dts: qcom-apq8064: Fix dsi and hdmi phy cells Andy Gross
2017-08-18  4:21 ` Archit Taneja [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae7f9349-9600-5798-2485-bffa54458b34@codeaurora.org \
    --to=architt@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).