From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E4F21E5B63; Mon, 27 Apr 2026 07:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777276701; cv=none; b=GHxyeXxkPhYx37pQFcM1I7COG3NcS+lGxBNuwgpRQiBN6bmxqST6AnaA2NGxXXzdsTdu1ino3LXKPcGmAlHJkT7iayDH7O8jH2+0ddUaw5r9SQxhQvwnzB3EXjqroYf3AFFujdaCKqAJkI9sPqKjjuwMdh/bfA9cuB/6fMdvaNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777276701; c=relaxed/simple; bh=NRFIPCjnwmWkGaHLJXSTXVOAj0P8uYVvyBr76C9hT0A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IbjcJ05nHaO+Demf4Yu9zKlX1AGq5mJMsoj5y0rdQfvpXCxd2ydPh4pIFYnpNZ1gnSKEe3oYt1luLvR/Y5O7dr3tO0qKMtUAldzSgfo6T69nwMyOZtoolou8VH25K243owbrZrOBvk3V9MrRUQNMLq/bwDdoxpQhXZ28WPxtIOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BAR78kOY; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BAR78kOY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777276701; x=1808812701; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NRFIPCjnwmWkGaHLJXSTXVOAj0P8uYVvyBr76C9hT0A=; b=BAR78kOYpZuh10YK4kJ1D9nHvJi6sJ0X3IWMirAa6vUPWokQoiNfuzVx tVvjVanqNBXpOwoIvp0OoacC3l4y/930By0F0ggRk2kLNyaYYjivLFOaO vZ0nMYWahL8zQHB8vYu3KQ573YEj4LWh92AoKeDH5IO4EwTcC1oAXgOb3 QEVzY6LGYucpeKZniWSIPchtxhpXjEQ17AYEqmlVNQTR1MnPqjbmSriBr mjvMULthjUtu2AG2ZtwwrIhRt1wB6WB8P+13oKKh3wC0Nw18zy7xtyFVE 3gHifIe47mx1C4aQ5HtB12/CqBTR+a1dctam4SpYsW6/fFmYBpNi16XUE Q==; X-CSE-ConnectionGUID: yNImV4rkTvGhcPeip6xC7A== X-CSE-MsgGUID: DhSQ40EXR5uN+/dgAVFgbw== X-IronPort-AV: E=McAfee;i="6800,10657,11768"; a="89621911" X-IronPort-AV: E=Sophos;i="6.23,201,1770624000"; d="scan'208";a="89621911" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 00:58:20 -0700 X-CSE-ConnectionGUID: 5RvKVfqpTDas2Vfh8NLAvg== X-CSE-MsgGUID: zxgV9PHiTIiM2zdlnrHw/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,201,1770624000"; d="scan'208";a="237889786" Received: from fpallare-mobl4.ger.corp.intel.com (HELO localhost) ([10.245.244.2]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 00:58:16 -0700 Date: Mon, 27 Apr 2026 10:58:13 +0300 From: Andy Shevchenko To: Antony Kurniawan Soemardi Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH v4 3/4] iio: adc: qcom-pm8xxx-xoadc: constify pointers in read operations Message-ID: References: <20260426-pm8xxx-xoadc-label-v4-0-0ec782362615@smankusors.com> <20260426-pm8xxx-xoadc-label-v4-3-0ec782362615@smankusors.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260426-pm8xxx-xoadc-label-v4-3-0ec782362615@smankusors.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sat, Apr 25, 2026 at 08:39:20PM +0000, Antony Kurniawan Soemardi wrote: > These functions do not modify the indio_dev & adc structure, so they > should be marked const to allow the compiler to catch any accidental > modifications and to document the read only nature of these functions. ... > - struct pm8xxx_xoadc *adc = iio_priv(indio_dev); > + const struct iio_dev *indio_dev = d; > + const struct pm8xxx_xoadc *adc = iio_priv(indio_dev); > > complete(&adc->complete); Pointer to a constant object assumes no modification to that, isn't it? Please, compile your code first. -- With Best Regards, Andy Shevchenko