From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Piyush Patle <piyushpatle228@gmail.com>
Cc: ak@it-klinger.de, jic23@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/7] iio: adc: hx711: introduce hx711_chip_info per-variant structure
Date: Mon, 27 Apr 2026 17:14:03 +0300 [thread overview]
Message-ID: <ae9vKxTrqe90OsCN@ashevche-desk.local> (raw)
In-Reply-To: <ae9t0WuhKgcPkfIt@ashevche-desk.local>
On Mon, Apr 27, 2026 at 05:08:17PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 27, 2026 at 03:39:35PM +0530, Piyush Patle wrote:
...
> > + chip_info = device_get_match_data(dev);
> > + if (!chip_info)
> > + return dev_err_probe(dev, -ENODEV, "missing match data\n");
>
> Since we are here, it's not match data, it's driver data. "missing driver data".
And does it need property.h to be included?
Also check if dev_printk.h and errno.h are there (it may be that driver already
uses device.h and err.h that cover these two).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-27 14:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 10:09 [PATCH v4 0/7] iio: adc: hx711: add HX710B support Piyush Patle
2026-04-27 10:09 ` [PATCH v4 1/7] dt-bindings: iio: adc: avia-hx711: add avia,hx710b compatible Piyush Patle
2026-04-27 15:29 ` David Lechner
2026-04-27 22:36 ` Piyush Patle
2026-04-28 17:49 ` Jonathan Cameron
2026-04-27 10:09 ` [PATCH v4 2/7] iio: adc: hx711: move scale computation to per-device storage Piyush Patle
2026-04-27 14:02 ` Andy Shevchenko
2026-04-27 22:38 ` Piyush Patle
2026-04-28 17:52 ` Jonathan Cameron
2026-04-27 10:09 ` [PATCH v4 3/7] iio: adc: hx711: update Kconfig, module description and file header Piyush Patle
2026-04-27 10:26 ` Joshua Crofts
2026-04-27 13:46 ` Andy Shevchenko
2026-04-27 13:49 ` Joshua Crofts
2026-04-28 17:54 ` Jonathan Cameron
2026-04-28 18:03 ` Joshua Crofts
2026-04-29 9:57 ` Andy Shevchenko
2026-04-29 10:27 ` Jonathan Cameron
2026-04-27 13:58 ` Andy Shevchenko
2026-04-27 14:19 ` Andy Shevchenko
2026-04-27 10:09 ` [PATCH v4 4/7] iio: adc: hx711: introduce hx711_chip_info per-variant structure Piyush Patle
2026-04-27 14:08 ` Andy Shevchenko
2026-04-27 14:14 ` Andy Shevchenko [this message]
2026-04-27 22:47 ` Piyush Patle
2026-04-28 17:57 ` Jonathan Cameron
2026-04-27 22:44 ` Piyush Patle
2026-04-27 10:09 ` [PATCH v4 5/7] iio: adc: hx711: pass trailing pulse count into hx711_read() Piyush Patle
2026-04-27 14:12 ` Andy Shevchenko
2026-04-27 22:49 ` Piyush Patle
2026-04-27 10:09 ` [PATCH v4 6/7] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read() Piyush Patle
2026-04-27 14:16 ` Andy Shevchenko
2026-04-27 10:09 ` [PATCH v4 7/7] iio: adc: hx711: add support for HX710B Piyush Patle
2026-04-27 14:34 ` Andy Shevchenko
2026-04-27 23:06 ` Piyush Patle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae9vKxTrqe90OsCN@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=piyushpatle228@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox