From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F8FC43219 for ; Fri, 14 Oct 2022 12:53:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbiJNMxV (ORCPT ); Fri, 14 Oct 2022 08:53:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbiJNMxT (ORCPT ); Fri, 14 Oct 2022 08:53:19 -0400 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D57EEE9840; Fri, 14 Oct 2022 05:53:18 -0700 (PDT) Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29EAN8tP021777; Fri, 14 Oct 2022 14:52:56 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=qpMDUU7rXBgiH6cy814AJNvQjHykFifpc/VwtmmGxPw=; b=ylbnGcQFOe9DBPx+9Akd097cODEqgt6mBnE4erUv4oM02JcjXJRWgQj1CsHk0gkdPyCn GrjwwIaT8WjxNZWT2B43FImjsFDg5oN/h6DW5AwVN6hBtwFRrnmX29KJmhbdGM6WnVfy iSw4rzDtpNwI54Yv2KgiUJFtxdZ1DK8jWCLFpXDc0nrFH/FMvHANjsZ/vxcFR7MzYYiV pA1dUjf5YZfWiux6nkeYqh3ZJ4hXksZbG7vAn1kz/MyVdBPHdTEnJ8UKvkkoz9ibqdTV uuhGglCYsG4d6Yjc5w8W/uFTmYZHakgF9eyhr4WmRQtixkEL30vBuyUKI790SbndrFXi Tg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3k64m7wfqj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 14:52:56 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 751DE100039; Fri, 14 Oct 2022 14:52:54 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 6FD2D229A9A; Fri, 14 Oct 2022 14:52:54 +0200 (CEST) Received: from [10.252.6.249] (10.75.127.51) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2375.31; Fri, 14 Oct 2022 14:52:50 +0200 Message-ID: Date: Fri, 14 Oct 2022 14:52:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v4 0/8] iio: stm32-adc: add support of adc for stm32mp13 Content-Language: en-US To: Olivier Moysan , Rob Herring , Alexandre Torgue , Andy Shevchenko , Jonathan Cameron , Lars-Peter Clausen , Maxime Coquelin CC: , , , , References: <20221012142205.13041-1-olivier.moysan@foss.st.com> From: Fabrice Gasnier In-Reply-To: <20221012142205.13041-1-olivier.moysan@foss.st.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-14_07,2022-10-14_01,2022-06-22_01 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/12/22 16:21, Olivier Moysan wrote: > On STM32MP13 SoCs, each ADC peripheral has a single ADC block. > These ADC peripherals, ADC1 and ADC2, are fully independent. > The STM32MP131 SoC provides only ADC2, while other STM32MP13x > SoCs provide both ADC1 and ADC2. > > The STM32MP13 ADC features and characteristics are slightly > different from STM32MP15 ADC ones, requiring a specific support > in the driver. > > This patchset enables the ADC peripheral on STM32MP135F-DK board. > > On STM32MP135F-DK board the ADC is connected to VDDA voltage > provided by the PMIC LOD1 supply, which has to be enabled through > SCMI regulator framework. > This serie introduces a fixed regulator to allow ADC probing, > while SCMI regulators support is not available. This does > not ensure ADC regulator enabling however. Hi Olivier, I've one tiny remark on PATCH 5/8, "ARM: dts: stm32: add adc support to stm32mp13" With that fixed, for the whole series, you can add my: Reviewed-by: Fabrice Gasnier Thanks, Fabrice > > Changes in v4: > - reformat patch 1 commit message > - reorder adc1 node > > v3: > - Remove blank line in tag block > - Use HZ_PER_MHZ unit for max frequency definition > - Coding style updates > > v2: > - Rework commit message length > - Add missing spaces > - Remove useless defines > > Olivier Moysan (8): > iio: adc: stm32-adc: fix channel sampling time init > dt-bindings: iio: adc: stm32-adc: add stm32mp13 compatibles > iio: adc: stm32-adc: add stm32mp13 support > iio: adc: stm32: manage min sampling time on all internal channels > ARM: dts: stm32: add adc support to stm32mp13 > ARM: dts: stm32: add adc pins muxing on stm32mp135f-dk > ARM: dts: stm32: add dummy vdd_adc regulator on stm32mp135f-dk > ARM: dts: stm32: add adc support on stm32mp135f-dk > > .../bindings/iio/adc/st,stm32-adc.yaml | 68 ++++- > arch/arm/boot/dts/stm32mp13-pinctrl.dtsi | 7 + > arch/arm/boot/dts/stm32mp131.dtsi | 43 +++ > arch/arm/boot/dts/stm32mp133.dtsi | 31 +++ > arch/arm/boot/dts/stm32mp135f-dk.dts | 33 +++ > drivers/iio/adc/stm32-adc-core.c | 30 ++- > drivers/iio/adc/stm32-adc-core.h | 30 +++ > drivers/iio/adc/stm32-adc.c | 247 +++++++++++++++--- > 8 files changed, 443 insertions(+), 46 deletions(-) >