devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
	patrick@stwcx.xyz, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 05/21] ARM: dts: aspeed: yosemite4: Revise quad mode to dual mode
Date: Thu, 01 Feb 2024 14:52:05 +1030	[thread overview]
Message-ID: <aebd29d6890e54e93b46a102e7ea7532ad7b32f4.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240131084134.328307-6-Delphine_CC_Chiu@wiwynn.com>

On Wed, 2024-01-31 at 16:41 +0800, Delphine CC Chiu wrote:
> Revise quad mode to dual mode to avoid WP pin influnece the SPI

What do you mean by this? Can you unpack what's going on a little more
in the commit message?

Andrew

> 
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> ---
>  .../arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index f8bfdefbefc6..23006dca5f26 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -149,15 +149,17 @@ flash@0 {
>  		status = "okay";
>  		m25p,fast-read;
>  		label = "bmc";
> -		spi-rx-bus-width = <4>;
> +		spi-tx-bus-width = <2>;
> +		spi-rx-bus-width = <2>;
>  		spi-max-frequency = <50000000>;
> -#include "openbmc-flash-layout-64.dtsi"
> +#include "openbmc-flash-layout-128.dtsi"
>  	};
>  	flash@1 {
>  		status = "okay";
>  		m25p,fast-read;
>  		label = "bmc2";
> -		spi-rx-bus-width = <4>;
> +		spi-tx-bus-width = <2>;
> +		spi-rx-bus-width = <2>;
>  		spi-max-frequency = <50000000>;
>  	};
>  };


  reply	other threads:[~2024-02-01  4:22 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31  8:41 [PATCH v5 00/21] Add i2c-mux and eeprom devices for Meta Yosemite 4 Delphine CC Chiu
2024-01-31  8:41 ` [PATCH v5 01/21] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu
2024-02-01  3:46   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 02/21] ARM: dts: aspeed: yosemite4: Enable adc15 Delphine CC Chiu
2024-02-01  4:13   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 03/21] ARM: dts: aspeed: yosemite4: Enable spi-gpio setting Delphine CC Chiu
2024-02-01  4:15   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 04/21] ARM: dts: aspeed: yosemite4: Enable watchdog2 Delphine CC Chiu
2024-02-01  5:34   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 05/21] ARM: dts: aspeed: yosemite4: Revise quad mode to dual mode Delphine CC Chiu
2024-02-01  4:22   ` Andrew Jeffery [this message]
2024-01-31  8:41 ` [PATCH v5 06/21] ARM: dts: aspeed: yosemite4: Revise power sensor adm1281 for schematic change Delphine CC Chiu
2024-02-01  4:24   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 07/21] ARM: dts: aspeed: yosemite4: Add gpio pca9506 Delphine CC Chiu
2024-02-01  5:35   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 08/21] ARM: dts: aspeed: yosemite4: Remove space for adm1272 compatible Delphine CC Chiu
2024-02-01  4:28   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 09/21] ARM: dts: aspeed: yosemite4: Enable interrupt setting for pca9555 Delphine CC Chiu
2024-02-01  4:33   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 10/21] ARM: dts: aspeed: yosemite4: Add power sensor for power module reading Delphine CC Chiu
2024-02-01  4:34   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 11/21] ARM: dts: aspeed: yosemite4: Add eeprom for yosemite4 use Delphine CC Chiu
2024-02-01  5:45   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 12/21] ARM: dts: aspeed: yosemite4: Remove temperature sensor for yosemite4 schematic change Delphine CC Chiu
2024-02-01  5:38   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 13/21] ARM: dts: aspeed: yosemite4: Revise adc128d818 adc mode " Delphine CC Chiu
2024-01-31  8:41 ` [PATCH v5 14/21] ARM: dts: aspeed: yosemite4: Revise ina233 config " Delphine CC Chiu
2024-01-31  8:41 ` [PATCH v5 15/21] ARM: dts: aspeed: yosemite4: Remove idle state setting for yosemite4 NIC connection Delphine CC Chiu
2024-02-01  5:47   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 16/21] ARM: dts: aspeed: yosemite4: Initialize bmc gpio state Delphine CC Chiu
2024-02-01  5:49   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 17/21] ARM: dts: aspeed: yosemite4: Revise mx31790 fan tach config Delphine CC Chiu
2024-01-31  8:41 ` [PATCH v5 18/21] ARM: dts: aspeed: yosemite4: add mctp config for NIC Delphine CC Chiu
2024-02-01  5:53   ` Andrew Jeffery
2024-01-31  8:41 ` [PATCH v5 19/21] ARM: dts: aspeed: yosemite4: support mux to cpld Delphine CC Chiu
2024-01-31  8:41 ` [PATCH v5 20/21] ARM: dts: aspeed: yosemite4: support medusa board adc sensors Delphine CC Chiu
2024-01-31  8:41 ` [PATCH v5 21/21] ARM: dts: aspeed: yosemite4: support NIC eeprom Delphine CC Chiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aebd29d6890e54e93b46a102e7ea7532ad7b32f4.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=Delphine_CC_Chiu@wiwynn.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick@stwcx.xyz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).