From: Guenter Roeck <linux@roeck-us.net>
To: "João Paulo Gonçalves" <jpaulo.silvagoncalves@gmail.com>
Cc: "Jean Delvare" <jdelvare@suse.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Farouk Bouabid" <farouk.bouabid@cherry.de>,
"Quentin Schulz" <quentin.schulz@cherry.de>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"João Paulo Gonçalves" <joao.goncalves@toradex.com>
Subject: Re: [PATCH v4 3/3] hwmon: (amc6821) Add cooling device support
Date: Sun, 15 Jun 2025 16:08:37 -0700 [thread overview]
Message-ID: <aec2567b-53e5-40bc-bbc5-0f2a1e9d19e2@roeck-us.net> (raw)
In-Reply-To: <20250613-b4-amc6821-cooling-device-support-v4-3-a8fc063c55de@toradex.com>
On Fri, Jun 13, 2025 at 10:42:40AM -0300, João Paulo Gonçalves wrote:
> From: João Paulo Gonçalves <joao.goncalves@toradex.com>
>
> Add support for using the AMC6821 as a cooling device. The AMC6821
> registers with the thermal framework only if the `cooling-levels`
> property is present in the fan device tree child node. If this property
> is present, the driver assumes the fan will operate in open-loop, and
> the kernel will control it directly. In this case, the driver will
> change the AMC6821 mode to manual (software DCY) and set the initial PWM
> duty cycle to the maximum fan cooling state level as defined in the DT.
> It is worth mentioning that the cooling device is registered on the
> child fan node, not on the fan controller node. Existing behavior is
> unchanged, so the AMC6821 can still be used without the thermal
> framework (hwmon only).
>
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2025-06-15 23:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 13:42 [PATCH v4 0/3] hwmon: (amc6821) Add cooling device support João Paulo Gonçalves
2025-06-13 13:42 ` [PATCH v4 1/3] dt-bindings: hwmon: amc6821: Add cooling levels João Paulo Gonçalves
2025-06-13 14:36 ` Conor Dooley
2025-06-15 23:05 ` Guenter Roeck
2025-06-13 13:42 ` [PATCH v4 2/3] hwmon: (amc6821) Move reading fan data from OF to a function João Paulo Gonçalves
2025-06-15 23:06 ` Guenter Roeck
2025-06-13 13:42 ` [PATCH v4 3/3] hwmon: (amc6821) Add cooling device support João Paulo Gonçalves
2025-06-15 23:08 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec2567b-53e5-40bc-bbc5-0f2a1e9d19e2@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=farouk.bouabid@cherry.de \
--cc=jdelvare@suse.com \
--cc=joao.goncalves@toradex.com \
--cc=jpaulo.silvagoncalves@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).