From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OcWmBnCE" Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40149194 for ; Fri, 17 Nov 2023 02:28:05 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-507b9408c61so2526752e87.0 for ; Fri, 17 Nov 2023 02:28:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700216883; x=1700821683; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EBrtAxlEr4GgfjZmKpLaY+8tcDXqNwU1BVb06jtClig=; b=OcWmBnCE/ICCCFSKmUVxPW5n+M5GsIA7rWSwtyoeWYCB8kJGz7SFBfHqajnkCzlQf4 E7RWo4R1x67WKS0AzucdxG80BYVTUo3ojtA4mDnaQ+yuzJxu3vP/ddHVLVfMSvCNjI12 Aem38FmbxpqlFRtVArQwXXtltb+t426Y0hyq8gvIwCEvPo5ui74JazJR6CG3pWJTP7Kx Jddx4Nq3xisb6eK8hgaa7x5Nq+4sCQzgNxaz2/ogCGHBwBvfX7o6pp1xvjk7YsWTY7Yv 7mP4+GdudkRrfcyg9RSjE+v+8sUZx2MgphPdk7WGWpAsgJCUYoGkTtG9bjSlbX0NJh58 P6bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700216883; x=1700821683; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EBrtAxlEr4GgfjZmKpLaY+8tcDXqNwU1BVb06jtClig=; b=MOcX5iuyjhowKyAeWO++Dq5zmzYnvi+KtNM5dZKvlvVspr9gfiWKFOv5fdZ6k25mwg ZsX5MLib05G282DfkGmFA2GLihK7CknjKEG6TpbAC9i/n9e4kA7A6XRymQrClnloD7hI 1aoRcUB8KVOKMIKjv9BCVu3ZRR+lPK8EQBUpOCESZggV1JZc4RCf9+kvk/vnDxFyzToh kUNJvAparZGAjUwa5U1rgm5iolFPnlx/3ao0Vx9U22wfmGyRLP3VuZDs3P90rT1Qx5vF QklhlGzx69pYKwYxi3D28f6WmdctVkegewzGMX/7sp5hxuR2TLSHcfTR0qQBHtXMdQXF MNdQ== X-Gm-Message-State: AOJu0Yzwk3aPxxHLQNN0/ylH66P9c2U3WO4Q89QY289a4Vd+Qu/PQfyJ v0KvH5aqYyJtRMQDkZjd8IVwyA== X-Google-Smtp-Source: AGHT+IHw/7drLyVYWVWFOIq2GW70aj0nhBeS5RXoyLJ3gCPAA/HqfATafNHqBQXC8Mlkwy9Vhlv77Q== X-Received: by 2002:a19:5518:0:b0:500:99a9:bc40 with SMTP id n24-20020a195518000000b0050099a9bc40mr12935886lfe.69.1700216883333; Fri, 17 Nov 2023 02:28:03 -0800 (PST) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id f16-20020a19ae10000000b005041a71237asm182106lfc.111.2023.11.17.02.28.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Nov 2023 02:28:02 -0800 (PST) Message-ID: Date: Fri, 17 Nov 2023 12:28:02 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/16] arm64: dts: qcom: sm8550-aim300: add SM8550 AIM300 Content-Language: en-GB To: Tengfei Fan , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, tglx@linutronix.de Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, -cc=kernel@quicinc.com References: <20231117101817.4401-1-quic_tengfan@quicinc.com> <20231117101817.4401-7-quic_tengfan@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <20231117101817.4401-7-quic_tengfan@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/11/2023 12:18, Tengfei Fan wrote: > Add a minimal DTS for the new QRD8550 board, serial, UFS and USB should > be working. An explanation of what is AIM300 would be welcomed. > > Signed-off-by: Tengfei Fan > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sm8550-aim300.dts | 490 +++++++++++++++++++++ > 2 files changed, 491 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sm8550-aim300.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index d6cb840b7050..ea5d4a07671a 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -229,5 +229,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8450-hdk.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8450-qrd.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx223.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx224.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sm8550-aim300.dtb My email client suggests that alignment is broken here. > dtb-$(CONFIG_ARCH_QCOM) += sm8550-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8550-qrd.dtb > diff --git a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts > new file mode 100644 > index 000000000000..202b979da8ca > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts > @@ -0,0 +1,490 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include > +#include "sm8550.dtsi" > +#include "pm8010.dtsi" > +#include "pm8550.dtsi" > +#include "pm8550b.dtsi" > +#include "pm8550ve.dtsi" > +#include "pm8550vs.dtsi" > +#include "pmk8550.dtsi" > +#include "pmr735d_a.dtsi" > +#include "pmr735d_b.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. SM8550 AIM300"; > + compatible = "qcom,sm8550-aim300", "qcom,sm8550"; > + > + aliases { > + serial0 = &uart7; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + pmic-glink { > + compatible = "qcom,sm8550-pmic-glink", "qcom,pmic-glink"; > + #address-cells = <1>; > + #size-cells = <0>; > + orientation-gpios = <&tlmm 11 GPIO_ACTIVE_HIGH>; > + > + connector@0 { > + compatible = "usb-c-connector"; > + reg = <0>; > + power-role = "dual"; > + data-role = "dual"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + pmic_glink_hs_in: endpoint { > + remote-endpoint = <&usb_1_dwc3_hs>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + pmic_glink_ss_in: endpoint { > + remote-endpoint = <&usb_1_dwc3_ss>; > + }; > + }; > + }; > + }; > + }; > + > + vph_pwr: vph-pwr-regulator { It's not demanded, I think, but I'd suggest 'regulator-vph-pwr' to allow all regulators to be grouped together. > + compatible = "regulator-fixed"; > + regulator-name = "vph_pwr"; > + regulator-min-microvolt = <3700000>; > + regulator-max-microvolt = <3700000>; > + > + regulator-always-on; > + regulator-boot-on; > + }; > +}; Other than that looks good to me. -- With best wishes Dmitry