From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D024C77B7A for ; Wed, 17 May 2023 15:10:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231533AbjEQPKf (ORCPT ); Wed, 17 May 2023 11:10:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231542AbjEQPKb (ORCPT ); Wed, 17 May 2023 11:10:31 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C66C81987; Wed, 17 May 2023 08:10:13 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab] (unknown [IPv6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 81954660588A; Wed, 17 May 2023 16:10:11 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1684336212; bh=BrW8utkPJOxoIND7izOm/XEslPXwZWFXJRck8b/4gfM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FuRybqK3UvoHRJVoF0gtJq7kqiuCcsKekfjjhb5FSLWjBNJklmmij6wRSym/gTVSd PeUmkXloGmT8DMC7ypKNSwpPCi7HwtIsTfb5dDltnzn7XyId5bDAHyBsuq99dbKbaO qV2acIPdh7HYFcfPWTHkypsPGJEgiqHDkL/41RfQYK3JvWfyc3bM/eqAEChYLWPkUK e3xuHQXJ9jR9m+sngBhcfi4FCD0PuoDq5/oqFLOmikXaNrbDjoHuuBLeYPTDFrkxOJ 0mRHrdJiPmYhd52jCx+gvylcbI/CezvomXKablFTISBJWRzIu6KZ9eO8GooGD38j+K u5x+MqDbpHy1w== Message-ID: Date: Wed, 17 May 2023 17:10:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 2/5] ASoC: mediatek: mt8188-mt6359: register hdmi/dp jack pins Content-Language: en-US To: =?UTF-8?B?VHJldm9yIFd1ICjlkLPmlofoia8p?= , "robh+dt@kernel.org" , "broonie@kernel.org" , "conor+dt@kernel.org" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "perex@perex.cz" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" References: <20230517111534.32630-1-trevor.wu@mediatek.com> <20230517111534.32630-3-trevor.wu@mediatek.com> <154497b3-f5c7-45d6-edd5-729642b80be5@collabora.com> <9685a64561fc90d592481ae5e95d1e849fe3c55b.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <9685a64561fc90d592481ae5e95d1e849fe3c55b.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 17/05/23 14:10, Trevor Wu (吳文良) ha scritto: > On Wed, 2023-05-17 at 13:31 +0200, AngeloGioacchino Del Regno wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> Il 17/05/23 13:15, Trevor Wu ha scritto: >>> Some userspace applications need jack control events, so register >>> hdmi >>> and dp jack pins to activate jack control events. >>> >>> Signed-off-by: Trevor Wu >>> --- >>> sound/soc/mediatek/mt8188/mt8188-mt6359.c | 27 >>> +++++++++++++++++++---- >>> 1 file changed, 23 insertions(+), 4 deletions(-) >>> >>> diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c >>> b/sound/soc/mediatek/mt8188/mt8188-mt6359.c >>> index 833bc362dad2..6c3f36e2fffd 100644 >>> --- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c >>> +++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c >>> @@ -151,6 +151,20 @@ struct mt8188_mt6359_priv { >>> struct snd_soc_jack hdmi_jack; >>> }; >>> >>> +static struct snd_soc_jack_pin mt8188_hdmi_jack_pins[] = { >>> + { >>> + .pin = "HDMI", >> >> "HDMI Jack" is more consistent with the snd_soc_jack_new_pins() call >> performed >> later. > > Hi Angelo, > > I see jack_kctl_name_gen() will append "Jack" to the name if I don't > name the pin "HDMI Jack". Do you mean that I could directly use "HDMI > Jack" because ALSA uses the name finally? > You're right and I just checked; the comment even says 'remove redundant " Jack" from src_name' So yes, the current names are fine. Sorry about that. Regards, Angelo