devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>
To: "nfraprado@collabora.com" <nfraprado@collabora.com>
Cc: "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
	"Yongqiang Niu (牛永强)" <yongqiang.niu@mediatek.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
	"nathan@kernel.org" <nathan@kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>,
	"ndesaulniers@google.com" <ndesaulniers@google.com>
Subject: Re: [PATCH v27 2/7] drm/mediatek: add ETHDR support for MT8195
Date: Fri, 4 Nov 2022 09:37:29 +0000	[thread overview]
Message-ID: <aef16e8fb787491e4cdba4b472f73aec38efe21c.camel@mediatek.com> (raw)
In-Reply-To: <20221103210315.lm2d3n4uolra44no@notapiano>

Dear Nicolas,

Thanks for the review.

On Thu, 2022-11-03 at 17:03 -0400, Nícolas F. R. A. Prado wrote:
> On Thu, Nov 03, 2022 at 11:26:05AM +0800, Nancy.Lin wrote:
> [..]
> > --- /dev/null
> > +++ b/drivers/gpu/drm/mediatek/mtk_ethdr.h
> 
> [..]
> > +void mtk_ethdr_unregister_vblank_cb(struct device *dev);
> > +void mtk_ethdr_enable_vblank(struct device *dev);
> > +void mtk_ethdr_disable_vblank(struct device *dev);
> > +#endif
> > +
> 
> As warned by git when applying the patch, you have an extra new line
> at the end
> here.
> 
> Applying: drm/mediatek: add ETHDR support for MT8195
> .git/rebase-apply/patch:454: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.

I will fix it.

Thanks
Nancy

  reply	other threads:[~2022-11-04  9:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20221103032610.9217-1-nancy.lin@mediatek.com>
     [not found] ` <20221103032610.9217-3-nancy.lin@mediatek.com>
2022-11-03 21:03   ` [PATCH v27 2/7] drm/mediatek: add ETHDR support for MT8195 Nícolas F. R. A. Prado
2022-11-04  9:37     ` Nancy Lin (林欣螢) [this message]
     [not found] ` <20221103032610.9217-7-nancy.lin@mediatek.com>
2022-11-03 21:28   ` [PATCH v27 6/7] drm/mediatek: add drm ovl_adaptor sub driver " Nícolas F. R. A. Prado
2022-11-04 10:57     ` Nancy Lin (林欣螢)
2022-11-04 14:53       ` Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aef16e8fb787491e4cdba4b472f73aec38efe21c.camel@mediatek.com \
    --to=nancy.lin@mediatek.com \
    --cc=Jason-JH.Lin@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=Singo.Chang@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=llvm@lists.linux.dev \
    --cc=matthias.bgg@gmail.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nfraprado@collabora.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=wim@linux-watchdog.org \
    --cc=yongqiang.niu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).