From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] regulator: dt-bindings: qcom,rpmh: document supplies per variant
Date: Mon, 11 Apr 2022 13:34:15 +0200 [thread overview]
Message-ID: <aefe5080-475b-946e-d6c7-1c39dc90da1c@linaro.org> (raw)
In-Reply-To: <20220411110344.231903-2-krzysztof.kozlowski@linaro.org>
On 11/04/2022 13:03, Krzysztof Kozlowski wrote:
> The RPMH regulator binding covers several devices with different
> regulator supplies, so it uses patterns matching broad range of these
> supplies. This works fine but is not specific and might miss actual
> mistakes when a wrong supply property is used for given variant.
>
> Add separate child schema which describes the supplies depending on the
> compatible.
(...)
> -additionalProperties: false
> -
> required:
> - compatible
> - qcom,pmic-id
>
> +allOf:
> + - $ref: qcom,rpmh-regulator-supplies.yaml#
> +
> +additionalProperties: false
This should be unevaluatedProperties:false, although this makes schema
matching any property. :(
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-11 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 11:03 [RFC PATCH 0/2] regulator: dt-bindings: qcom,rpmh: minor cleanups and extend supplies Krzysztof Kozlowski
2022-04-11 11:03 ` [RFC PATCH 1/2] regulator: dt-bindings: qcom,rpmh: document supplies per variant Krzysztof Kozlowski
2022-04-11 11:34 ` Krzysztof Kozlowski [this message]
2022-04-11 11:03 ` [RFC PATCH 2/2] regulator: dt-bindings: qcom,rpmh: document vdd-l7-bob-supply on PMR735A Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aefe5080-475b-946e-d6c7-1c39dc90da1c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).