From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Praveen Talari <quic_ptalari@quicinc.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: qcom: geni-se-qup: Add compatible for Nord SoC
Date: Thu, 23 Apr 2026 19:06:59 +0800 [thread overview]
Message-ID: <aen9U_3jMRagJwgp@QCOM-aGQu4IUr3Y> (raw)
In-Reply-To: <20260420064401.1248833-1-shengchao.guo@oss.qualcomm.com>
On Mon, Apr 20, 2026 at 02:44:01PM +0800, Shawn Guo wrote:
> From: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
>
> Add compatibles for GENI Serial Engine QUP Wrapper Controller on Nord SoC
> with fallback on SA8255P compatibles.
>
> Signed-off-by: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> ---
> .../soc/qcom/qcom,sa8255p-geni-se-qup.yaml | 20 +++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,sa8255p-geni-se-qup.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,sa8255p-geni-se-qup.yaml
> index 352af3426d34..d73f9edcbbdb 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,sa8255p-geni-se-qup.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,sa8255p-geni-se-qup.yaml
> @@ -19,7 +19,12 @@ description:
>
> properties:
> compatible:
> - const: qcom,sa8255p-geni-se-qup
> + oneOf:
> + - enum:
> + - qcom,sa8255p-geni-se-qup
> + - items:
> + - const: qcom,nord-auto-geni-se-qup
AUTO variant of Nord is SA8797P, so it makes more sense to use
'qcom,sa8797p-geni-se-qup' which is more consistent to
'qcom,sa8255p-geni-se-qup'. Will update in the next version.
Shawn
> + - const: qcom,sa8255p-geni-se-qup
>
> reg:
> description: QUP wrapper common register address and length.
> @@ -67,9 +72,16 @@ patternProperties:
>
> properties:
> compatible:
> - enum:
> - - qcom,sa8255p-geni-uart
> - - qcom,sa8255p-geni-debug-uart
> + oneOf:
> + - enum:
> + - qcom,sa8255p-geni-uart
> + - qcom,sa8255p-geni-debug-uart
> + - items:
> + - const: qcom,nord-auto-geni-uart
> + - const: qcom,sa8255p-geni-uart
> + - items:
> + - const: qcom,nord-auto-geni-debug-uart
> + - const: qcom,sa8255p-geni-debug-uart
>
> required:
> - compatible
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-04-23 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 6:44 [PATCH] dt-bindings: qcom: geni-se-qup: Add compatible for Nord SoC Shawn Guo
2026-04-20 8:33 ` Rob Herring (Arm)
2026-04-21 8:17 ` Shawn Guo
2026-04-23 11:06 ` Shawn Guo [this message]
2026-04-23 12:08 ` Rob Herring
2026-04-23 14:44 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aen9U_3jMRagJwgp@QCOM-aGQu4IUr3Y \
--to=shengchao.guo@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=deepti.jaggi@oss.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=quic_ptalari@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox