From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B7FAEE49A9 for ; Sat, 19 Aug 2023 07:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344494AbjHSHyV (ORCPT ); Sat, 19 Aug 2023 03:54:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344445AbjHSHxu (ORCPT ); Sat, 19 Aug 2023 03:53:50 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB1E63C0A for ; Sat, 19 Aug 2023 00:53:47 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b95d5ee18dso25954081fa.1 for ; Sat, 19 Aug 2023 00:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692431626; x=1693036426; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4pXGd50QS4NhntuldSaEKZY1dWgEwQEkHWL/LnltV2k=; b=G37Z+JIuW+ZIy6lQ86mLGfC+7dfURD6nBWdGQ7d7dwSNXxLGXFYf9L0q68Hk2tUJVw i5rrlT+xmCMci1EyDCpxkbY4DMGXl7ueagtN3wZ0NiOqDZU6Ra3AGOfPAc/1S4gV+Zls U3wXVgE0BH3imk0WgfvzyJu473aaxnP/yDCq2CQHq2yRVqvgjTw/FPPzAHEz5IUYVEIO VVCZebACKfEgoguZzAIF1ccegEE7W3KAsbRA4CgdfUudMfsP+yH01YJ9rggIs+KNyQcI Wtp/uloNOusvQ+F7W01mDuKENUzDMqw4q8pe/ET9c+tXMnbjPmsfXT45fL342jvxUmH4 t1tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692431626; x=1693036426; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4pXGd50QS4NhntuldSaEKZY1dWgEwQEkHWL/LnltV2k=; b=frVYKQ7xpcFtfszstFyamCj7Zgo8jxcrPGKOuGTemU5+7SYi2lZzb4PLZwjAxwh19j sdOFwSB7oyrhiSL6UjGwfqLBG754vEQx7QDoAMT1VpBWgOlXh0MLbeOOJfRlXX5Us4YI Se3rjXGIchmGlYnGXUxdng2dLZJ713dH9Q5uU2Mt/CfqCnzvEbh4JyeDLgGTh6QKszpT mUY2+T9g6QA+TW+ZPB2/Oqcs3jeAZGQGKglabcwwURl5crVeiIJhYv94smo9Ax3vXWY1 rDCncm0o4J1IhY5lTsOtfyczj5ghqmcJKGULFuQdExagS8DLrWM9O0CZcGfBz7VazRyj 3SSA== X-Gm-Message-State: AOJu0Yz0zZ/nX87Coci6+iZpz/yofJy/B9Vq6c+axvhNvEW2HX9YFwEy grDhyKTZKk1fMPyk4WwwHZ0l3Q== X-Google-Smtp-Source: AGHT+IEw8pMqEZB8rNtxqDrqr24o9F2PuqslrZMx0sM0n63duTUAkpDaJX/IL/c0f1kXuTlW5MnyEw== X-Received: by 2002:ac2:5bde:0:b0:4fe:63cf:6048 with SMTP id u30-20020ac25bde000000b004fe63cf6048mr745210lfn.43.1692431626061; Sat, 19 Aug 2023 00:53:46 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id l7-20020a17090615c700b00999bb1e01dfsm2240704ejd.52.2023.08.19.00.53.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Aug 2023 00:53:45 -0700 (PDT) Message-ID: Date: Sat, 19 Aug 2023 09:53:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 0/1] Add add-maintainer.py script Content-Language: en-US To: Masahiro Yamada , Nick Desaulniers , Andrew Morton , Nicolas Schier , Kees Cook , Bjorn Andersson , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Will Deacon , Greg Kroah-Hartman , quic_pkondeti@quicinc.com, u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org References: <20230810185526.GC31860@quicinc.com> <4d94d0fd-72d4-0196-3a30-3e1efb9f5aca@linaro.org> <20230816171538.GB26279@quicinc.com> <6fb1176f-90f1-7a65-3ab5-f6447418c51e@linaro.org> <20230819013303.GA22393@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230819013303.GA22393@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/08/2023 03:33, Guru Das Srinagesh wrote: > On Aug 18 2023 10:43, Krzysztof Kozlowski wrote: >>>> For newcomers, OTOH, I would either recommend simple workflow or just >>>> use b4. Why? Because if you cannot use git-send-email, then it means >>>> your email setup will make your life difficult and adding maintainers to >>>> existing patch won't help you. >>> >>> You've mentioned a "simple workflow" many times - could you please share more >>> details on the steps you follow in your workflow for sending patches? >> >> I shared it on LKML few times already (and Rob's git send-email identity >> is also on LKML), so one more time: >> >> https://github.com/krzk/tools/blob/master/linux/.bash_aliases_linux#L91 > > Thank you for sharing this - it is really neat indeed and you certainly don't > need a step #2 with this method. > > However, I see areas for improvement in the alias: > - Subsystem-specific mailing lists, maintainers, reviewers, and other roles are > all marked as "To: " sans distinction via the alias whereas > `add-maintainer.py` and `b4` both provide marking of lists as "Cc: " which > seems aesthetically and semantically more pleasing. To or Cc does not matter. > - Only `add-maintainer.py` allows for maintainers to be selectively in "To: " > and "Cc: " for patches in a series depending on whether they are the > maintainers for that particular patch or not. It's intentional to CC everyone. If I wanted to Cc/To maintainer-per-patch, I would use Rob's send-email identity. > >>>> This tool depends on the command line and shell interface of >>>> scripts/get_maintainers.pl which is another reason why it might not be a >>>> good idea. >>> >>> Could you please elaborate on why depending on the output of >>> `get_maintainer.pl` is a bad idea? It's what everyone uses, no? >> >> No, because if interface changes you need to update two tools. > > But `b4 prep --auto-to-cc` also uses `get_maintainer.pl`! Yep, and it's Konstantin's headache to keep it updated. :) > > Also, in your previous email you said to "just use b4", which also depends on > the command line and shell interface of `get_maintainers.pl`. Depending on > `get_maintainer.pl` is therefore perfectly okay - there is no need to reinvent > it or disregard it for whatever reasons. True, it is okay, but adding more tools to depend on it is more work. b4 is awesome tool, thus I feel it is justified to depend on that interface. I don't see the need for more tools doing exactly the same. Best regards, Krzysztof