From: Krzysztof Kozlowski <krzk@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, upstream@airoha.com
Subject: Re: [PATCH v3 2/4] dt-bindings: clock: drop NUM_CLOCKS define for EN7581
Date: Thu, 19 Dec 2024 13:28:59 +0100 [thread overview]
Message-ID: <af251ba3-660b-4281-84aa-a715eb83039b@kernel.org> (raw)
In-Reply-To: <20241219121902.16339-2-ansuelsmth@gmail.com>
On 19/12/2024 13:18, Christian Marangi wrote:
> Drop NUM_CLOCKS define for EN7581 include. This is not a binding and
> should not be placed here. Value is derived internally in the user
> driver.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> Changes v3:
> - Add this patch
>
> include/dt-bindings/clock/en7523-clk.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h
> index c4f8a161b981..edfa64045f52 100644
> --- a/include/dt-bindings/clock/en7523-clk.h
> +++ b/include/dt-bindings/clock/en7523-clk.h
> @@ -14,6 +14,4 @@
>
> #define EN7581_CLK_EMMC 8
>
> -#define EN7523_NUM_CLOCKS 8
Are you sure your patchset bisects?
Also better to arrange cleanups before new clocks added, so lack of
conflict between number of clocks and new clock ID is obvious.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-19 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 12:18 [PATCH v3 1/4] dt-bindings: clock: add ID for eMMC for EN7581 Christian Marangi
2024-12-19 12:18 ` [PATCH v3 2/4] dt-bindings: clock: drop NUM_CLOCKS define " Christian Marangi
2024-12-19 12:28 ` Krzysztof Kozlowski [this message]
2024-12-19 12:30 ` Christian Marangi
2024-12-19 12:44 ` Krzysztof Kozlowski
2024-12-19 12:18 ` [PATCH v3 3/4] clk: en7523: Rework clock handling for different clock numbers Christian Marangi
2024-12-19 12:18 ` [PATCH v3 4/4] clk: en7523: Add clock for eMMC for EN7581 Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af251ba3-660b-4281-84aa-a715eb83039b@kernel.org \
--to=krzk@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox