From: "Rafał Miłecki" <zajec5@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
"maintainer:BROADCOM IPROC ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM IPROC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Kurt Kanzenbach <kurt@kmk-computers.de>
Subject: Re: [PATCH 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node
Date: Wed, 11 Nov 2020 14:06:40 +0100 [thread overview]
Message-ID: <af2d0f49-38a9-d7df-8848-40050a2d5c85@gmail.com> (raw)
In-Reply-To: <20201110033113.31090-5-f.fainelli@gmail.com>
On 10.11.2020 04:31, Florian Fainelli wrote:
> Provide a default compatible string which is based on the 53010 SRAB
> compatible, this allows us to have sane defaults and silences the
> following warnings:
>
> arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml:
> ethernet-switch@18007000: compatible: 'oneOf' conditional failed, one
> must be fixed:
> ['brcm,bcm5301x-srab'] is too short
> 'brcm,bcm5325' was expected
> 'brcm,bcm53115' was expected
> 'brcm,bcm53125' was expected
> 'brcm,bcm53128' was expected
> 'brcm,bcm5365' was expected
> 'brcm,bcm5395' was expected
> 'brcm,bcm5389' was expected
> 'brcm,bcm5397' was expected
> 'brcm,bcm5398' was expected
> 'brcm,bcm11360-srab' was expected
> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm53010-srab',
> 'brcm,bcm53011-srab', 'brcm,bcm53012-srab', 'brcm,bcm53018-srab',
> 'brcm,bcm53019-srab']
> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm11404-srab',
> 'brcm,bcm11407-srab', 'brcm,bcm11409-srab', 'brcm,bcm58310-srab',
> 'brcm,bcm58311-srab', 'brcm,bcm58313-srab']
> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm58522-srab',
> 'brcm,bcm58523-srab', 'brcm,bcm58525-srab', 'brcm,bcm58622-srab',
> 'brcm,bcm58623-srab', 'brcm,bcm58625-srab', 'brcm,bcm88312-srab']
> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm3384-switch',
> 'brcm,bcm6328-switch', 'brcm,bcm6368-switch']
> From schema:
> Documentation/devicetree/bindings/net/dsa/b53.yaml
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/boot/dts/bcm5301x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index ee23c0841699..807580dd89f5 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -483,7 +483,7 @@ thermal: thermal@1800c2c0 {
> };
>
> srab: ethernet-switch@18007000 {
> - compatible = "brcm,bcm5301x-srab";
> + compatible = "brcm,bcm53010-srab", "brcm,bcm5301x-srab";
I've never seen Northstar device with BCM53010, see below list.
*** BCM47081 ***
Buffalo WZR-600DHP2
[ 1.816948] b53_common: found switch: BCM53011, rev 2
Luxul XWR-1200 V1
[ 2.602445] b53_common: found switch: BCM53011, rev 5
TP-LINK Archer C5 V2
[ 0.606353] b53_common: found switch: BCM53011, rev 5
*** BCM4708 ***
Buffalo WZR-1750DHP
[ 1.961584] b53_common: found switch: BCM53011, rev 2
Netgear R6250 V1
[ 2.445594] b53_common: found switch: BCM53011, rev 2
SmartRG SR400ac
[ 4.258116] b53_common: found switch: BCM53011, rev 5
*** BCM4709 ***
TP-LINK Archer C9 V1
[ 0.640041] b53_common: found switch: BCM53012, rev 5
*** BCM47094 ***
D-Link DIR-885L
[ 1.373423] b53_common: found switch: BCM53012, rev 0
Luxul XWR-3150 V1
[ 5.893989] b53_common: found switch: BCM53012, rev 0
Luxul XAP-1610 V1
[ 0.761285] b53_common: found switch: BCM53012, rev 0
next prev parent reply other threads:[~2020-11-11 13:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 3:31 [PATCH 00/10] Broadcom b53 YAML bindings Florian Fainelli
2020-11-10 3:31 ` [PATCH 01/10] dt-bindings: net: dsa: Extend switch nodes pattern Florian Fainelli
2020-11-10 19:42 ` Vladimir Oltean
2020-11-11 22:24 ` Rob Herring
2020-11-10 3:31 ` [PATCH 02/10] dt-bindings: net: dsa: Document sfp and managed properties Florian Fainelli
2020-11-11 22:33 ` Rob Herring
2020-11-10 3:31 ` [PATCH 03/10] ARM: dts: BCM5301X: Update Ethernet switch node name Florian Fainelli
2020-11-10 19:46 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node Florian Fainelli
2020-11-10 22:06 ` Vladimir Oltean
2020-11-10 22:11 ` Florian Fainelli
2020-11-11 13:06 ` Rafał Miłecki [this message]
2020-11-10 3:31 ` [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node Florian Fainelli
2020-11-10 9:31 ` Rafał Miłecki
2020-11-10 15:46 ` Florian Fainelli
2020-11-10 22:12 ` Vladimir Oltean
2020-11-10 22:13 ` Florian Fainelli
2020-11-11 1:48 ` Florian Fainelli
2020-11-11 12:27 ` Rafał Miłecki
2020-11-10 3:31 ` [PATCH 06/10] ARM: dts: NSP: Update ethernet switch node name Florian Fainelli
2020-11-10 22:16 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 07/10] ARM: dts: NSP: Fix Ethernet switch SGMII register name Florian Fainelli
2020-11-10 22:27 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 08/10] ARM: dts: NSP: Add a default compatible for switch node Florian Fainelli
2020-11-10 22:37 ` Vladimir Oltean
2020-11-10 22:40 ` Florian Fainelli
2020-11-10 22:48 ` Vladimir Oltean
2020-11-10 22:52 ` Florian Fainelli
2020-11-10 23:06 ` Vladimir Oltean
2020-11-10 3:31 ` [PATCH 09/10] ARM: dts: NSP: Provide defaults ports container node Florian Fainelli
2020-11-10 3:31 ` [PATCH 10/10] dt-bindings: net: dsa: b53: Add YAML bindings Florian Fainelli
2020-11-10 13:21 ` Kurt Kanzenbach
2020-11-10 15:46 ` Florian Fainelli
2020-11-10 22:43 ` Vladimir Oltean
2020-11-11 22:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af2d0f49-38a9-d7df-8848-40050a2d5c85@gmail.com \
--to=zajec5@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=kurt@kmk-computers.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).