From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04062C77B7A for ; Wed, 17 May 2023 08:15:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229923AbjEQIPY (ORCPT ); Wed, 17 May 2023 04:15:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229747AbjEQIPX (ORCPT ); Wed, 17 May 2023 04:15:23 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 054953AA3 for ; Wed, 17 May 2023 01:15:19 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-966400ee79aso79769566b.0 for ; Wed, 17 May 2023 01:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684311317; x=1686903317; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cEe5FsJ/vwnENYwLAm7Rnaraj/b22HuPaXqzWSqjWEc=; b=AldKz2t3x6SeZni7O0UeJvok2PBlQ75nnUFErAixCYwRxGPOgLgYJdNycoXO6okk0M kHWwmYkjJug7tSPeX3f7R0Vf7Pg6sTGr5i4jNIzLSpJOKbuPAirUjIA01XpyRydk7DzY 54wLBQOd6a+bFFwKCY+/wlX/YttddYELPmqznUui/qZjJfCvD+KC4UFvh9+ecT1alRoZ XbzP3iUIZcLJ2XzGQ7dDBE1axXjfEQvHhESnOtm/LXLy4NVa+txhT7mIc4fQ3Ej+ScHJ xlnP24D9EakmKBRsccuqlETmXs7pjU1ZRHmpna+7v/PtdTGwWfZf2XVV8fn9iz2UWIDl WeXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684311317; x=1686903317; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cEe5FsJ/vwnENYwLAm7Rnaraj/b22HuPaXqzWSqjWEc=; b=AxE70dvNw2OWk3c4cZ2aEnmiNO9zCm1XMgOZQTB0DFhx/D/XiYwKKD8R1qgiNPnZwr gERQJkdt5HO9c4XWm/02tSNllyvIIrkfV9ST6KpDVorzc16vAj9rvLA9zzzpC7QE5bo1 jOdLHWKxp5De4z9fD7qgQpVnH9BFfMFzFGgLVyPZG1AHkOTpgI8H+EbXVpVe32zNXuwe yMKwbAJHjQcdkqW7sU4a3LvaNTUqARruP/n5qtRrg9QJ3ncrsUOxcmCPxlyoEIT0U2nj BOlvamV8YsYczH4elFJwkin/nYFxN1NyiWFvAnWwUDr8sHFJ29yhZKZN+3095rw6bARh MVrQ== X-Gm-Message-State: AC+VfDyUPvJweS3knkhuBUwRXwJMxWsWqp3jBger4V8Pcm+16QMhcapk Heq9TBU2OYURNl7NWIyWh+Mfv1mxPoUH79Af+bw= X-Google-Smtp-Source: ACHHUZ6gRO9CPqhoqv2ttZfqInxP1k1DHikZHSV6X47AFfVd7gqcPWGHfGjXXhM4cr/lhIS+cnO1Kw== X-Received: by 2002:a17:907:9285:b0:966:484a:3350 with SMTP id bw5-20020a170907928500b00966484a3350mr28458711ejc.35.1684311317473; Wed, 17 May 2023 01:15:17 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:c9ff:4c84:dd21:568d? ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id z13-20020a17090674cd00b0096ae152115bsm6040064ejl.175.2023.05.17.01.15.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 01:15:16 -0700 (PDT) Message-ID: Date: Wed, 17 May 2023 10:15:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] arm64: dts: qcom: sm8550-qrd: add PCIe0 Content-Language: en-US To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230516133011.108093-1-krzysztof.kozlowski@linaro.org> <2e6f282c-33d9-7f96-0338-c4fd457d04fa@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/05/2023 19:15, Dmitry Baryshkov wrote: > On Tue, 16 May 2023 at 19:43, Krzysztof Kozlowski > wrote: >> >> On 16/05/2023 18:39, Dmitry Baryshkov wrote: >>> On Tue, 16 May 2023 at 16:30, Krzysztof Kozlowski >>> wrote: >>>> >>>> Add PCIe0 nodes used with WCN7851 device. The PCIe1 is not connected, >>>> thus skip pcie_1_phy_aux_clk input clock to GCC. >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> --- >>>> arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 32 +++++++++++++++++++++++++ >>>> 1 file changed, 32 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts >>>> index ccc58e6b45bd..e7a2bc5d788b 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts >>>> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts >>>> @@ -385,6 +385,38 @@ vreg_l3g_1p2: ldo3 { >>>> }; >>>> }; >>>> >>>> +&gcc { >>>> + clocks = <&bi_tcxo_div2>, <&sleep_clk>, >>>> + <&pcie0_phy>, >>>> + <&pcie1_phy>, >>>> + <0>, >>>> + <&ufs_mem_phy 0>, >>>> + <&ufs_mem_phy 1>, >>>> + <&ufs_mem_phy 2>, >>>> + <&usb_dp_qmpphy QMP_USB43DP_USB3_PIPE_CLK>; >>>> +}; >>> >>> Is there any reason to disable the PCIe1 PHY AUX clock here? I mean, >>> the PCIe1 is still enabled in the hardware. >> >> I was thinking about this. The AUX clock seems to be an external clock, >> although I could not find it in schematics. I assume that on QRD8550 it >> could be missing, if it is really external. OTOH, downstream DTS did not >> seem to care... > > I might be completely wrong here, but I think that AUX clock is yet > another clock provided by the PHY to the GCC, which we were just > ignoring for now. For example, for sm8450 we have <0> there. I don't > see it as an external clock, so I think it is internal to the SoC. Hm, in that case it would make sense to keep it here. It's frequency, with some safe choice, could also go to DTSI. Best regards, Krzysztof