From: Andrew Lunn <andrew@lunn.ch>
To: Jonas Rebmann <jre@pengutronix.de>
Cc: Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
David Jander <david@protonic.nl>,
Lucas Stach <l.stach@pengutronix.de>,
Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH v2 3/3] arm64: dts: add Protonic PRT8ML board
Date: Thu, 18 Sep 2025 16:14:28 +0200 [thread overview]
Message-ID: <af554442-aeec-40d2-a35a-c7ee5bfcb99a@lunn.ch> (raw)
In-Reply-To: <20250918-imx8mp-prt8ml-v2-3-3d84b4fe53de@pengutronix.de>
> + port@4 {
> + reg = <4>;
> + ethernet = <&fec>;
> + label = "cpu";
> + phy-mode = "rgmii-id";
> + rx-internal-delay-ps = <2000>;
> + tx-internal-delay-ps = <2000>;
> +
> + fixed-link {
> + full-duplex;
> + speed = <100>;
> + };
> + };
> + };
> + };
> +};
> +
> +&fec {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_fec>;
> + phy-mode = "rgmii"; /* switch inserts delay */
> + rx-internal-delay-ps = <0>;
> + tx-internal-delay-ps = <0>;
> + status = "okay";
> +
> + fixed-link {
> + full-duplex;
> + speed = <100>;
> + };
You have an RGMII interface, but you run it at 100Mbps? That might be
worth a comment somewhere to explain why.
Andrew
next prev parent reply other threads:[~2025-09-18 14:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 12:19 [PATCH v2 0/3] Mainline Protonic PRT8ML board Jonas Rebmann
2025-09-18 12:19 ` [PATCH v2 1/3] dt-bindings: net: dsa: nxp,sja1105: Add reset-gpios property Jonas Rebmann
2025-09-18 15:32 ` Frank Li
2025-09-22 17:33 ` Rob Herring (Arm)
2025-09-22 17:35 ` Vladimir Oltean
2025-09-18 12:19 ` [PATCH v2 2/3] dt-bindings: arm: fsl: Add Protonic PRT8ML Jonas Rebmann
2025-09-18 12:19 ` [PATCH v2 3/3] arm64: dts: add Protonic PRT8ML board Jonas Rebmann
2025-09-18 14:14 ` Andrew Lunn [this message]
2025-09-18 14:51 ` David Jander
2025-09-18 15:04 ` Andrew Lunn
2025-09-18 15:33 ` David Jander
2025-09-19 5:08 ` Oleksij Rempel
2025-09-19 7:31 ` David Jander
2025-09-18 14:18 ` Andrew Lunn
2025-09-18 15:01 ` Jonas Rebmann
2025-09-18 14:50 ` [PATCH v2 0/3] Mainline " Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af554442-aeec-40d2-a35a-c7ee5bfcb99a@lunn.ch \
--to=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jre@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox