From: Philipp Zabel <p.zabel@pengutronix.de>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 1/2] dt-bindings: net: Add rfkill-gpio binding
Date: Mon, 02 Jan 2023 18:40:58 +0100 [thread overview]
Message-ID: <af5dd2c21d7805315e719f8b0fd163bcaa6aea39.camel@pengutronix.de> (raw)
In-Reply-To: <e99d6756-e275-7dd6-a57f-1c9a120b4ef3@kernel.org>
On Do, 2022-12-22 at 11:20 +0100, Krzysztof Kozlowski wrote:
> On 21/12/2022 11:48, Philipp Zabel wrote:
> > Add a device tree binding document for GPIO controlled rfkill switches.
> > The name, type, shutdown-gpios and reset-gpios properties are the same
> > as defined for ACPI.
> >
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> You missed several maintainers. Resend.
Thank you for the review, I've sent a v2:
https://lore.kernel.org/all/20230102-rfkill-gpio-dt-v2-0-d1b83758c16d@pengutronix.de/T
[...]
>
>
> > + shutdown-gpios:
> > + maxItems: 1
> > +
> > + reset-gpios:
> > + maxItems: 1
>
> Reset of rfkill? It seems entire binding is a workaround of missing
> reset in your device. I don't think this is suitable for binding.
I've dropped the reset-gpios property. The device I would like to
control with this is the 'wireless disable' pin of an M.2 connector.
regards
Philipp
prev parent reply other threads:[~2023-01-02 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 10:48 [PATCH 1/2] dt-bindings: net: Add rfkill-gpio binding Philipp Zabel
2022-12-21 10:48 ` [PATCH 2/2] net: rfkill: gpio: add DT support Philipp Zabel
2022-12-22 10:32 ` Krzysztof Kozlowski
2022-12-21 14:45 ` [PATCH 1/2] dt-bindings: net: Add rfkill-gpio binding Rob Herring
2022-12-21 15:36 ` Philipp Zabel
2022-12-22 10:32 ` Krzysztof Kozlowski
2022-12-22 10:20 ` Krzysztof Kozlowski
2023-01-02 17:40 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af5dd2c21d7805315e719f8b0fd163bcaa6aea39.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).