From: Andrew Jackson <andrew.jackson@arm.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rajeev Kumar <rajeevkumar.linux@gmail.com>,
Andrew Jackson <Andrew.Jackson@arm.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Arnd Bergmann <arnd@arndb.de>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v5 1/6] ASoC: dwc: Switch to managed clock resource
Date: Tue, 30 Dec 2014 10:55:43 +0000 [thread overview]
Message-ID: <af6e23a9f11ead4b8abd1f70dbf634964253b37f.1419936132.git.Andrew.Jackson@arm.com> (raw)
In-Reply-To: <cover.1419936132.git.Andrew.Jackson@arm.com>
In-Reply-To: <cover.1419936132.git.Andrew.Jackson@arm.com>
From: Andrew Jackson <Andrew.Jackson@arm.com>
Simplify error handling during probe by using managed clock
resources.
Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com>
---
sound/soc/dwc/designware_i2s.c | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
index 06d3a34..5e9d163 100644
--- a/sound/soc/dwc/designware_i2s.c
+++ b/sound/soc/dwc/designware_i2s.c
@@ -407,13 +407,13 @@ static int dw_i2s_probe(struct platform_device *pdev)
dev->capability = pdata->cap;
dev->i2s_clk_cfg = pdata->i2s_clk_cfg;
- dev->clk = clk_get(&pdev->dev, NULL);
+ dev->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(dev->clk))
return PTR_ERR(dev->clk);
ret = clk_enable(dev->clk);
if (ret < 0)
- goto err_clk_put;
+ return ret;
dev_set_drvdata(&pdev->dev, dev);
ret = snd_soc_register_component(&pdev->dev, &dw_i2s_component,
@@ -427,19 +427,13 @@ static int dw_i2s_probe(struct platform_device *pdev)
err_clk_disable:
clk_disable(dev->clk);
-err_clk_put:
- clk_put(dev->clk);
return ret;
}
static int dw_i2s_remove(struct platform_device *pdev)
{
- struct dw_i2s_dev *dev = dev_get_drvdata(&pdev->dev);
-
snd_soc_unregister_component(&pdev->dev);
- clk_put(dev->clk);
-
return 0;
}
--
1.7.1
next prev parent reply other threads:[~2014-12-30 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 10:55 [PATCH v5 0/6] ASoC: dwc: Add device tree support to designware I2S Andrew Jackson
2014-12-30 10:55 ` Andrew Jackson [this message]
[not found] ` <af6e23a9f11ead4b8abd1f70dbf634964253b37f.1419936132.git.Andrew.Jackson-5wv7dgnIgG8@public.gmane.org>
2014-12-30 16:49 ` [PATCH v5 1/6] ASoC: dwc: Switch to managed clock resource Mark Brown
2014-12-30 10:55 ` [PATCH v5 2/6] ASoC: dwc: Prepare clock before use Andrew Jackson
2014-12-30 12:39 ` Sergei Shtylyov
2014-12-30 16:51 ` Mark Brown
2014-12-30 10:55 ` [PATCH v5 3/6] ASoC: dwc: Read I2S block configuration from registers Andrew Jackson
2014-12-30 10:55 ` [PATCH v5 4/6] ASoC: dwc: Register components with managed interface Andrew Jackson
2014-12-30 10:55 ` [PATCH v5 5/6] ASoC: dwc: Add documentation for I2S DT Andrew Jackson
2014-12-30 16:52 ` Mark Brown
2014-12-30 10:55 ` [PATCH v5 6/6] ASoC: dwc: Add devicetree support for Designware I2S Andrew Jackson
[not found] ` <8da45b000fb1f9a029b30fcf5abe50941f45e32e.1419936132.git.Andrew.Jackson-5wv7dgnIgG8@public.gmane.org>
2014-12-30 16:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af6e23a9f11ead4b8abd1f70dbf634964253b37f.1419936132.git.Andrew.Jackson@arm.com \
--to=andrew.jackson@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=rajeevkumar.linux@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).