From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4568437646B; Thu, 23 Apr 2026 12:01:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945721; cv=none; b=PuHnLkLe7l6/+OVXyOPQxIfINXdmKJPOpWEQ8iw4bSY4mQhyq9v/sLErJww5wqHVzxIbLu9jP7VdmkLdzZPwzrRwNBLVVB38fO7Vi1YLs0WD/+TUsLJrxnp6onjUuXAdiX9jVgZfi1pQI/pvkJfM8ZPLDHOdrQaSQX2HNxKDU+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945721; c=relaxed/simple; bh=Fx938U2Vfj0K/y5jh7enFEPw/OYujGES1OBKTsXTLso=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WGipBoJpwrxkYhyYqxTukU1MuSLS8uj24GxGcHDIYf1Z/n+V3/8g1SzQxLNB1NqexKqmM48pbgNr2KxiHLIyl3XbcSdod1gRW7eJ8kgstXaUS1o2jxZ9FI9wYfsgzalXfypMuSniPkWGADinK5/V7m/Oxmo3+t036Bx6BSyCvSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=hYU+Rth/; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="hYU+Rth/" Received: from [192.168.88.20] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 030669A4; Thu, 23 Apr 2026 14:00:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1776945617; bh=Fx938U2Vfj0K/y5jh7enFEPw/OYujGES1OBKTsXTLso=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hYU+Rth/LWlUi09SWn3C1ojFeB3bob/ROPmYmxTjEC+TzCblfv6fwLHZ97Aoxhp8q KK8aYt7qWstD46FDSAt3LHGL8oq4RUzkmxaXoMS6iHzRJTHxKBVlJJ4rXcZ+UltJ3o 0oDuaK1K8Wnvw9XxASotvt1EjrM5algZ1YOzfjdY= Message-ID: Date: Thu, 23 Apr 2026 15:01:51 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] drm/panel: simple: Add timings for Raspberry Pi 7" panel To: Dmitry Baryshkov Cc: Dave Stevenson , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260420-rpi-7inch-v1-0-e68d5c9c44bc@ideasonboard.com> <20260420-rpi-7inch-v1-2-e68d5c9c44bc@ideasonboard.com> <3z3u5mbngmbzsch3mzs3twlh3aec6r7jokstzv3ghxyusrzt6b@jqvdnuiapx6e> Content-Language: en-US From: Tomi Valkeinen In-Reply-To: <3z3u5mbngmbzsch3mzs3twlh3aec6r7jokstzv3ghxyusrzt6b@jqvdnuiapx6e> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 22/04/2026 22:22, Dmitry Baryshkov wrote: > On Mon, Apr 20, 2026 at 04:13:36PM +0300, Tomi Valkeinen wrote: >> Add timings for the panel used in Raspberry Pi 7" DSI Display module: >> https://www.raspberrypi.com/products/raspberry-pi-touch-display/ >> >> This has been tested with version v1.1 of the display module. >> >> The panel is very strict about the back-porch values, they must be >> exactly 46 for hbp and 23 for vbp. Other timings can be defined quite >> freely. >> >> The panel is exclusive to Raspberry Pi, and different versions of the >> display module can have panels from different vendors which are fully >> compatible. Also, as the panel vendors are not public, the compatible >> string used is "raspberrypi,7inch-dsi". >> >> Note that while the display module has a DSI connector, and the >> compatible has "dsi" in it, we use DRM_MODE_CONNECTOR_DPI as the panel >> itself is a parallel video panel. The display module (as of v1.1) uses >> TC358762 DSI-to-DPI bridge to do the conversion. >> >> We could use DRM_MODE_CONNECTOR_DSI here, which would have the benefit >> of showing a "DSI-1" connector to the userspace. However, the panel IS a >> DPI panel, and gets its input from a DSI-to-DPI bridge, and the >> panel-simple.c behaves differently depending on the connector type used, >> so, DRM_MODE_CONNECTOR_DPI it is. >> >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index 91ab280869ba..e75eb20301f2 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -4208,6 +4208,35 @@ static const struct panel_desc rocktech_rk043fn48h = { >> .connector_type = DRM_MODE_CONNECTOR_DPI, >> }; >> >> +static const struct display_timing raspberrypi_7inch_timing = { >> + .pixelclock = { 10000000, 30000000, 50000000 }, >> + .hactive = { 800, 800, 800 }, >> + .hfront_porch = { 16, 72, 354 }, >> + .hsync_len = { 1, 32, 40 }, >> + .hback_porch = { 46, 46, 46 }, >> + .vactive = { 480, 480, 480 }, >> + .vfront_porch = { 7, 21, 147 }, >> + .vsync_len = { 1, 2, 20 }, >> + .vback_porch = { 23, 23, 23 }, >> + .flags = DISPLAY_FLAGS_VSYNC_HIGH | DISPLAY_FLAGS_HSYNC_HIGH, >> + /* Note: the rest of the flags are defined below in bus_flags */ >> +}; > > This looks pretty close to powertip panels that have been used before > hand in those modules. Are you sure that powertip,ph800480t013-idf02 > or powertip,ph800480t032-zhc19 don't work for you? I haven't tested those, but the hbp and vbp do not seem to be the same. For me, they had to be exactly as they are here. This was also confirmed from Raspberry Pi, the panel datasheet had min/typ/max values (i.e. not ranges) of 46 and 23 for back porches. Where did the information come from that powertip,ph800480t013-idf02 or powertip,ph800480t032-zhc19 are used in the display modules? Or did you mean that while those models are not used in the Raspberry display module, people have used them successfully? Tomi