* [PATCH V2] arm64: dts: qcom: qcm6490: Add UFS nodes
@ 2023-12-21 11:19 Manish Pandey
2023-12-21 13:58 ` Konrad Dybcio
0 siblings, 1 reply; 2+ messages in thread
From: Manish Pandey @ 2023-12-21 11:19 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_cang, quic_nguyenb,
quic_mapa, quic_nitirawa, quic_bhaskarv, quic_narepall,
quic_rampraka, quic_ahari
Add UFS host controller and Phy nodes for
Qualcomm qcm6490 Board.
Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>
---
Changes from v1:
- updated with correct patchset
---
arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index 03e97e27d16d..51efd46b576c 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -440,6 +440,25 @@
status = "okay";
};
+&ufs_mem_hc {
+ reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
+ vcc-supply = <&vreg_l7b_2p9>;
+ vcc-max-microamp = <800000>;
+ vccq-supply = <&vreg_l9b_1p2>;
+ vccq-max-microamp = <900000>;
+ vccq2-supply = <&vreg_l9b_1p2>;
+ vccq2-max-microamp = <900000>;
+
+ status = "okay";
+};
+
+&ufs_mem_phy {
+ vdda-phy-supply = <&vreg_l10c_0p8>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
+
+ status = "okay";
+};
+
&usb_1 {
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] arm64: dts: qcom: qcm6490: Add UFS nodes
2023-12-21 11:19 [PATCH V2] arm64: dts: qcom: qcm6490: Add UFS nodes Manish Pandey
@ 2023-12-21 13:58 ` Konrad Dybcio
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2023-12-21 13:58 UTC (permalink / raw)
To: Manish Pandey, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_cang, quic_nguyenb,
quic_nitirawa, quic_bhaskarv, quic_narepall, quic_rampraka,
quic_ahari
On 21.12.2023 12:19, Manish Pandey wrote:
> Add UFS host controller and Phy nodes for
> Qualcomm qcm6490 Board.
>
> Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>
> ---
> Changes from v1:
> - updated with correct patchset
Well no, this clearly hasn't been compile-tested..
Please also include the board name in the subject
(qcm6490: -> qcm6490-idp:)
>
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index 03e97e27d16d..51efd46b576c 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -440,6 +440,25 @@
> status = "okay";
> };
>
> +&ufs_mem_hc {
> + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
> + vcc-supply = <&vreg_l7b_2p9>;
> + vcc-max-microamp = <800000>;
> + vccq-supply = <&vreg_l9b_1p2>;
> + vccq-max-microamp = <900000>;
> + vccq2-supply = <&vreg_l9b_1p2>;
> + vccq2-max-microamp = <900000>;
These regulators should get regulator-allow-set-load since the
UFS driver expects to perform current/mode setting ops on them
Konrad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-21 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-21 11:19 [PATCH V2] arm64: dts: qcom: qcm6490: Add UFS nodes Manish Pandey
2023-12-21 13:58 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).