From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: lpass-va: add npl clock for new VA macro
Date: Fri, 18 Nov 2022 15:41:46 +0100 [thread overview]
Message-ID: <af7f1b14-6b46-54af-19fd-de8d1de535db@linaro.org> (raw)
In-Reply-To: <c3a2316f-2956-6417-f1ea-a6a64df037c6@linaro.org>
On 18/11/2022 15:38, Krzysztof Kozlowski wrote:
> On 18/11/2022 08:18, Srinivas Kandagatla wrote:
>> LPASS VA Macro now has soundwire master to deal with access to
>> analog mic in low power island use cases. This also means that VA macro
>> now needs to get hold of the npl clock too. Add clock bindings required
>> for this.
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
... and not.
+ clock-names:
+ items:
+ - const: mclk
+ - const: core
+ - const: dcodec
This neither matches DTS nor driver. Did you test DTS with the bindings
change?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-18 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 7:18 [PATCH v2 0/2] ASoC: codec: lpass-va: add npl clock support Srinivas Kandagatla
2022-11-18 7:18 ` [PATCH v2 1/2] ASoC: dt-bindings: lpass-va: add npl clock for new VA macro Srinivas Kandagatla
2022-11-18 14:38 ` Krzysztof Kozlowski
2022-11-18 14:41 ` Krzysztof Kozlowski [this message]
2022-12-24 14:40 ` Krzysztof Kozlowski
2022-11-18 7:18 ` [PATCH v2 2/2] ASoC: codecs: va-macro: add npl clk Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af7f1b14-6b46-54af-19fd-de8d1de535db@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).