From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA601C001DB for ; Mon, 7 Aug 2023 13:51:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234464AbjHGNvu (ORCPT ); Mon, 7 Aug 2023 09:51:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234458AbjHGNvs (ORCPT ); Mon, 7 Aug 2023 09:51:48 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17C3210DD for ; Mon, 7 Aug 2023 06:51:47 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-52256241c66so9645628a12.1 for ; Mon, 07 Aug 2023 06:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691416305; x=1692021105; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5U7uXQPqJdJRTybbD7UWkq4hcpTzTPPBe48JRQK60d8=; b=siUwPP6TAI6SSnVRXaqAXAkU8Y+9KQFZNj8SGOBskXBIh5sKvzKy5gY3yyHBWgiERn bhmarSHyd6YFmvOXWtq7r29XxO6ht/vgMpJSHrL8LpRBWtOblDd1S2qDnQBiMvbYE0ig 1m0no4m00eF9Cs8ietNs0mpAFHuFT8/OUqmSZgq10I0uJMOqax04L67CiRZK5pHAk+gT pDLWYzbvzWdq/b5se479A9NNUxiZxS2MM3+bApIBYpjn/K3kF0smFqXVoJLP5ta97b/Y z4//rrJqg3X35F14zrNDD7PWe3JNaHiEp3ezuFaSKEP7UQoLbUVonTYJmzsRLbPxKLfp ojPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691416305; x=1692021105; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5U7uXQPqJdJRTybbD7UWkq4hcpTzTPPBe48JRQK60d8=; b=gze2Y5J9qsdAioWCtNs0k8e6I5zQpg4pLIBDxv441bz45fM5E7ldNXVotM076UT84i mcuniEWOIuay7CHDhzgMGTUoZ6hE+HZPIpscUWFPd66lcBwjBfKAxLe7tlYZ3uFR2twa H3lxK9THoRXqgNChQ4phUF99joFUopdroIAUR9QaIKl3bXP6Ma/FnVYcCkzWwk6gkszF Wd5cTl7iES754bQMau2tSeh0AlLCVc3WMZMFNZgIHnKlEnqJlQnl9bDf+YG11DKE4KF/ WfV09YHI93WNCeNo1bq4avA3cyCmjoJkWtREzfD2hJOB3DqgdVbz6KNYsFBw/qTr3MOs dYIQ== X-Gm-Message-State: AOJu0YzkxDIXX5adwekB9LAPtWEQnzAAEZX/3OOFXyiqcmZCgYGt09uq 5x8ycapd/CjIx629+c0/ACnXfQ== X-Google-Smtp-Source: AGHT+IFHT60GM0SzX9TXq5wlvNhwlntdej2m89q9MKu3133qU0DChWx1leGNQ8gUg3hl1tGkiS5DKQ== X-Received: by 2002:a05:6402:51d2:b0:521:ef0f:8ef9 with SMTP id r18-20020a05640251d200b00521ef0f8ef9mr8152852edd.19.1691416305604; Mon, 07 Aug 2023 06:51:45 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id e26-20020a50ec9a000000b0051873c201a0sm5195571edr.26.2023.08.07.06.51.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 06:51:45 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 15:51:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 4/4] ARM: configs: s5pv210_defconfig: enable IIO required by MAX17040 Content-Language: en-US To: Andi Shyti Cc: Svyatoslav Ryhel , Iskren Chernev , Marek Szyprowski , Matheus Castello , Sebastian Reichel , Rob Herring , Conor Dooley , Russell King , Alim Akhtar , Arnd Bergmann , Jernej Skrabec , Claudiu Beznea , Stefan Hansson , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20230731073613.10394-1-clamor95@gmail.com> <20230731073613.10394-5-clamor95@gmail.com> <20230805224211.qquexvseq24hxcju@intel.intel> <16047849-1001-4d6f-4995-0fdfc065cded@linaro.org> <20230807085543.3tfzpsa2joolay3r@intel.intel> From: Krzysztof Kozlowski In-Reply-To: <20230807085543.3tfzpsa2joolay3r@intel.intel> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/08/2023 10:55, Andi Shyti wrote: > Hi, > > On Sun, Aug 06, 2023 at 10:29:04AM +0200, Krzysztof Kozlowski wrote: >> On 06/08/2023 00:42, Andi Shyti wrote: >>> Hi Svyatoslav, >>> >>> On Mon, Jul 31, 2023 at 10:36:13AM +0300, Svyatoslav Ryhel wrote: >>>> After adding support for passing temperature data from thermal sensor >>>> to MAX17040 it got dependency on CONFIG_IIO. From all defconfigs >>>> using MAX17040 only s5pv210_defconfig did not have IIO already enabled >>>> so let's enable it to avoid regression. >>>> >>>> Signed-off-by: Svyatoslav Ryhel >>>> --- >>>> arch/arm/configs/s5pv210_defconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/arch/arm/configs/s5pv210_defconfig b/arch/arm/configs/s5pv210_defconfig >>>> index 4c1e480b5bbd..24070ee3d43e 100644 >>>> --- a/arch/arm/configs/s5pv210_defconfig >>>> +++ b/arch/arm/configs/s5pv210_defconfig >>>> @@ -97,6 +97,7 @@ CONFIG_MMC_SDHCI_S3C_DMA=y >>>> CONFIG_RTC_CLASS=y >>>> CONFIG_RTC_DRV_MAX8998=m >>>> CONFIG_DMADEVICES=y >>>> +CONFIG_IIO=y >>>> CONFIG_PWM=y >>>> CONFIG_PWM_SAMSUNG=y >>>> CONFIG_PHY_SAMSUNG_USB2=m >>> >>> Should this patch be squashed to the previous patch? I think you >>> break bisectability for this board if you enable iio only here. >> >> The defconfig change matters less - distros don't use them - so this >> points to the fact that patchset affected the users. All existing users >> of max17040 drivers, who do not enable IIO, will have their setups broken. > > That's why I'm suggesting to squash this patch with the previous. It would not solve much. All existing users will be still broken. > > Anyway, up to you... except of this note everything looks fine in > the series. I would actually prefer not to depend on IIO, but this would require stubs for missing IIO functions. Best regards, Krzysztof