From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE2D1C433FE for ; Thu, 5 May 2022 15:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351575AbiEEPH6 (ORCPT ); Thu, 5 May 2022 11:07:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243206AbiEEPH5 (ORCPT ); Thu, 5 May 2022 11:07:57 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A300B56430; Thu, 5 May 2022 08:04:18 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 754D41F45912 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651763057; bh=CvWL0d92LTexS+0TabDQSn5dqaw57JFYhNx34gLvT+4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FymySwbCbDQl4GF3l/lIkKKEPFBziW0d1hu4fmNOOGncPJRlggPbECJOkic3hNT4K cl9A3RkP/QPmQDeirnZHyngRLX4MiVEMNuB47cfXJDaf9/N04OxMj6DVK9KqCli+eY HBxIeetLXKDJqR+9jTcyxpK6KqMhCt8/Rge//og6LNx/ealuvT/J03zU0NUjfGmG+q S7N3hSGeKfBF8wmWRrHdtQq+dGZ9cH6VPj6PjhHU6wm9ToIptVUtdhRqPbjq4PvcSi k0fH6vBYIICtwFYmnIrAXhTSSAICy1h1N7HiosBncuBXhwud9Ul1ibgP5YYY7BzoAz z/rTsZqbcatTA== Message-ID: Date: Thu, 5 May 2022 17:04:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v6 02/10] cpufreq: mediatek: Add platform_device_unregister when driver exit Content-Language: en-US To: Rex-BC Chen , rafael@kernel.org, viresh.kumar@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org, matthias.bgg@gmail.com Cc: jia-wei.chang@mediatek.com, roger.lu@mediatek.com, hsinyi@google.com, khilman@baylibre.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220505115226.20130-1-rex-bc.chen@mediatek.com> <20220505115226.20130-3-rex-bc.chen@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220505115226.20130-3-rex-bc.chen@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 05/05/22 13:52, Rex-BC Chen ha scritto: > We register the platform device when driver inits. However, we do not > unregister it when driver exits. > To resolve this, we declare the platform data to be a global static > variable and rename it to be "cpufreq_pdev". > With this global variable, we can do platform_device_unregister() when > driver exits. > > Signed-off-by: Rex-BC Chen Hello Rex, this commit needs a Fixes: tag. Cheers, Angelo