From: Mark Brown <broonie@kernel.org>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH] dt-bindings: regulator: fcs,fan53555: Remove vsel-gpios property
Date: Tue, 28 Apr 2026 10:00:10 +0900 [thread overview]
Message-ID: <afAGmqGtHpVXzyKr@sirena.co.uk> (raw)
In-Reply-To: <20260427115443.3224840-1-eagle.alexander923@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
On Mon, Apr 27, 2026 at 02:54:43PM +0300, Alexander Shiyan wrote:
> - vsel-gpios:
> - description: Voltage Select. When this pin is LOW, VOUT is set by the
> - VSEL0 register. When this pin is HIGH, VOUT is set by the VSEL1 register.
> - maxItems: 1
In addition to Conor's concerns have you checked for existing usage?
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-04-28 1:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 11:54 [PATCH] dt-bindings: regulator: fcs,fan53555: Remove vsel-gpios property Alexander Shiyan
2026-04-27 19:04 ` Conor Dooley
2026-04-27 19:09 ` Alexander Shiyan
2026-04-27 19:59 ` Conor Dooley
2026-04-28 0:54 ` Mark Brown
2026-04-28 1:00 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afAGmqGtHpVXzyKr@sirena.co.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eagle.alexander923@gmail.com \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox