From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jia Wang <wangjia@ultrarisc.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 2/4] serial: 8250_dw: build Renesas RZN1 CPR value from DW_UART_CPR_* definitions
Date: Wed, 29 Apr 2026 12:05:32 +0300 [thread overview]
Message-ID: <afHJ3DArX34FQMuY@ashevche-desk.local> (raw)
In-Reply-To: <177742420562.3222151.9689419292413018986.b4-reply@b4>
On Wed, Apr 29, 2026 at 08:56:45AM +0800, Jia Wang wrote:
> On 2026-04-28 13:58 +0300, Andy Shevchenko wrote:
> > On Tue, Apr 28, 2026 at 05:07:49PM +0800, Jia Wang wrote:
> > > On 2026-04-28 11:41 +0300, Ilpo Järvinen wrote:
...
> > > Thanks. I tried that approach, but the statement-expression form does
> > > not work in this case because the helper is used in static initializers.
> > > So I'll keep it as a plain expression macro for now, and just rework it
> > > into a cleaner multi-line form.
> >
> > Still you can move FIELD_PREP_CONST() into it.
>
> Right, I'll move FIELD_PREP_CONST() in. By the way, does your Reviewed-by
> still hold?
Not for this patch, as it seems we get too many modifications and discussions
around. Let have a fresh look in v6 (the rest of the patches are okay, please
keep tags there).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-29 9:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 5:26 [PATCH v5 0/4] serial: 8250_dw: Add support for UltraRISC DP1000 UART Jia Wang
2026-04-28 5:26 ` [PATCH v5 1/4] serial: 8250_dwlib: move DesignWare register definitions to header Jia Wang
2026-04-28 7:15 ` Andy Shevchenko
2026-04-28 5:26 ` [PATCH v5 2/4] serial: 8250_dw: build Renesas RZN1 CPR value from DW_UART_CPR_* definitions Jia Wang
2026-04-28 7:28 ` Andy Shevchenko
2026-04-28 8:36 ` Jia Wang
2026-04-28 8:41 ` Ilpo Järvinen
2026-04-28 9:07 ` Jia Wang
2026-04-28 10:58 ` Andy Shevchenko
2026-04-29 0:56 ` Jia Wang
2026-04-29 9:05 ` Andy Shevchenko [this message]
2026-04-28 10:57 ` Andy Shevchenko
2026-04-28 5:26 ` [PATCH v5 3/4] dt-bindings: serial: snps-dw-apb-uart: Add UltraRISC DP1000 UART Jia Wang
2026-04-28 5:26 ` [PATCH v5 4/4] serial: 8250_dw: Use a fixed CPR value for " Jia Wang
2026-04-28 8:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afHJ3DArX34FQMuY@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=wangjia@ultrarisc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox