Re: [PATCH v4 4/7] iio: adc: hx711: introduce hx711_chip_info per-variant structure

Piyush Patle
2026-04-27T22:47:59Z

On Mon, Apr 27, 2026 at 7:44 PM Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
>
> On Mon, Apr 27, 2026 at 05:08:17PM +0300, Andy Shevchenko wrote:
> > On Mon, Apr 27, 2026 at 03:39:35PM +0530, Piyush Patle wrote:
>
> ...
>
> > > + chip_info = device_get_match_data(dev);
> > > + if (!chip_info)
> > > + return dev_err_probe(dev, -ENODEV, "missing match data\n");
> >
> > Since we are here, it's not match data, it's driver data. "missing driver data".
>
> And does it need property.h to be included?
>
property.h is already present in the driver

> Also check if dev_printk.h and errno.h are there (it may be that driver already
> uses device.h and err.h that cover these two).
platform_device.h pulls in device.h which covers dev_err_probe().
err.h covers the errno values. No new includes are needed for this patch.

>
> --
> With Best Regards,
> Andy Shevchenko
>
>