public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Piyush Patle <piyushpatle228@gmail.com>
Cc: ak@it-klinger.de, jic23@kernel.org, dlechner@baylibre.com,
	nuno.sa@analog.com, andy@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/11] iio: adc: hx711: add HX710B support
Date: Wed, 29 Apr 2026 22:08:30 +0300	[thread overview]
Message-ID: <afJXLrw0XyFBdt0Y@ashevche-desk.local> (raw)
In-Reply-To: <20260429054544.123862-1-piyushpatle228@gmail.com>

On Wed, Apr 29, 2026 at 11:15:33AM +0530, Piyush Patle wrote:
> Add support for the AVIA HX710B ADC, a HX711-compatible converter with
> the same GPIO interface but a different channel-selection model and a
> fixed gain of 128.
> 
> Compared to v4, this series is split more finely to match the review
> boundaries requested during review rather than because the feature
> itself grew materially:
> 
> - the DT binding work is now split into cleanup of the existing HX711
>   binding, HX711-only VSUP documentation, HX711-only RATE GPIO
>   documentation, and the HX710B binding addition
> - the driver refactoring is now split further so the trailing-pulse
>   parameterization, loop-iterator cleanup, and hx711_reset() declaration
>   cleanup all stand alone
> - the Kconfig help text, file header, and MODULE_DESCRIPTION updates now
>   sit adjacent to the final HX710B support patch instead of appearing in
>   the middle of the refactor sequence
> 
> The resulting series is longer than v4, but each patch is narrower and
> maps more directly to the requested review boundaries.
> 
> Tested on PocketBeagle2 with an HX710B breakout module. The device
> probed successfully, all three channels returned stable raw readings,
> and alternating reads confirmed channel switching between the
> differential input and the DVDD-AVDD supply monitor path.
> 
> Build-tested with:
> - make -s W=1 drivers/iio/adc/hx711.o
> - make -s dt_binding_check \
>   DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> - pahole -C hx711_chip_info drivers/iio/adc/hx711.o
> 
> pahole reports hx711_chip_info as 40 bytes with no internal holes. The
> remaining 7 bytes are tail padding from 8-byte pointer alignment.

This is almost ready-to-push series. I have a few nit-picks here and there,
most important ones are the patch organisation (splitting) and the question
about new entries in the buffer structure.

I believe next version will be final (but wait until we settle down on the
opens).

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2026-04-29 19:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29  5:45 [PATCH v5 0/11] iio: adc: hx711: add HX710B support Piyush Patle
2026-04-29  5:45 ` [PATCH v5 01/11] dt-bindings: iio: adc: hx711: clean up existing binding text Piyush Patle
2026-04-29  5:45 ` [PATCH v5 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property Piyush Patle
2026-04-29  5:45 ` [PATCH v5 03/11] dt-bindings: iio: adc: hx711: add RATE GPIO property Piyush Patle
2026-04-29  5:45 ` [PATCH v5 04/11] dt-bindings: iio: adc: hx711: add HX710B support Piyush Patle
2026-04-29  5:45 ` [PATCH v5 05/11] iio: adc: hx711: move scale computation to per-device storage Piyush Patle
2026-04-29 18:41   ` Andy Shevchenko
2026-04-29  5:45 ` [PATCH v5 06/11] iio: adc: hx711: introduce hx711_chip_info structure Piyush Patle
2026-04-29 18:44   ` Andy Shevchenko
2026-04-29  5:45 ` [PATCH v5 07/11] iio: adc: hx711: pass trailing pulse count into hx711_read Piyush Patle
2026-04-29 18:53   ` Andy Shevchenko
2026-04-29  5:45 ` [PATCH v5 08/11] iio: adc: hx711: localize loop iterators in hx711_read Piyush Patle
2026-04-29 15:01   ` Joshua Crofts
2026-04-29 18:51     ` Andy Shevchenko
2026-04-29 18:49   ` Andy Shevchenko
2026-04-29  5:45 ` [PATCH v5 09/11] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read Piyush Patle
2026-04-29 18:54   ` Andy Shevchenko
2026-04-29  5:45 ` [PATCH v5 10/11] iio: adc: hx711: split hx711_reset variable assignment Piyush Patle
2026-04-29 18:55   ` Andy Shevchenko
2026-04-29  5:45 ` [PATCH v5 11/11] iio: adc: hx711: add support for HX710B Piyush Patle
2026-04-29 19:06   ` Andy Shevchenko
2026-05-04 15:56     ` Jonathan Cameron
2026-04-29 19:08 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afJXLrw0XyFBdt0Y@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=ak@it-klinger.de \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=piyushpatle228@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox