From: Mark Brown <broonie@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
KancyJoe <kancy2333@outlook.com>
Subject: Re: [PATCH v2 2/2] regulator: add SGM3804 Dual Output driver
Date: Fri, 1 May 2026 08:46:56 +0900 [thread overview]
Message-ID: <afPp8DXSLQIkQNaK@sirena.co.uk> (raw)
In-Reply-To: <150cdb85-d0ac-4802-a09b-9dab1b9b805a@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Thu, Apr 30, 2026 at 03:28:43PM +0200, Neil Armstrong wrote:
> On 4/30/26 12:34, Mark Brown wrote:
> > On Thu, Apr 30, 2026 at 10:48:47AM +0200, Neil Armstrong wrote:
> > > +// SPDX-License-Identifier: GPL-2.0-only
> > > +/*
> > > + * SGMicro SGM3804 regulator Driver
> > > + *
> > > + * Copyright (C) 2025 Kancy Joe <kancy2333@outlook.com>
> > > + * Copyright (C) 2026 Linaro Limited
> > > + * Author: Neil Armstrong <neil.armstrong@linaro.org>
> > > + */
> > Please make the entire comment block a C++ one so things look more
> > intentional.
> Sure, converted into:
> + * Copyright (C) 2026 Linaro Limited (Neil Armstrong <neil.armstrong@linaro.org>)
That's not the issue - that's not converting into a C++ comment.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-30 23:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 8:48 [PATCH v2 0/2] regulator: add support for SGM3804 Dual Output driver Neil Armstrong
2026-04-30 8:48 ` [PATCH v2 1/2] regulator: dt-bindings: document the SGM3804 Dual Output regulator Neil Armstrong
2026-04-30 10:25 ` Rob Herring (Arm)
2026-04-30 8:48 ` [PATCH v2 2/2] regulator: add SGM3804 Dual Output driver Neil Armstrong
2026-04-30 10:34 ` Mark Brown
2026-04-30 13:28 ` Neil Armstrong
2026-04-30 23:46 ` Mark Brown [this message]
2026-05-04 6:55 ` Neil Armstrong
2026-05-04 12:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afPp8DXSLQIkQNaK@sirena.co.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kancy2333@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox