From: Bjorn Andersson <andersson@kernel.org>
To: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: glymur: Add psci reboot-mode edl
Date: Sat, 9 May 2026 22:28:01 -0500 [thread overview]
Message-ID: <af_49utiHCPDlbEd@baldur> (raw)
In-Reply-To: <20260505-glymur_reboot_mode-v1-1-59fe3e9a6868@oss.qualcomm.com>
On Tue, May 05, 2026 at 07:07:27PM +0530, Pankaj Patil wrote:
> Add PSCI SYSTEM_RESET2 reboot-modes for glymur to be invoked by the psci
"Glymur"
> reboot-mode driver.
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
states that you should start your commit message by describing the
"problem" your patch is addressing. This commit message fully assumes
that the reader already knows everything about this topic and why this
should be added.
>
> The following modes are defined:
> - edl: reboot into emergency download mode for image loading via
> the Firehose protocol.
I presume that would be the Sahara protocol, but you don't need to be
specific about how that implementation works. It's sufficient to say
that "edl" reboots the device into "emergency download mode (EDL)".
>
> Support for these modes is dependent on the psci firmware
What are the implications of that?
>
> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 6 ++++++
> arch/arm64/boot/dts/qcom/glymur.dtsi | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> index 2852d257ac8c..397519e95ca1 100644
> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> @@ -560,6 +560,12 @@ &pon_resin {
> status = "okay";
> };
>
> +&psci {
> + reboot-mode {
> + mode-edl = <0x80000000 0x1>;
Does the statement about "psci firmware" somehow relate to the fact that
this is defined in the crd.dtsi?
> + };
> +};
> +
> &tlmm {
> gpio-reserved-ranges = <4 4>, /* EC TZ Secure I3C */
> <10 2>, /* OOB UART */
> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> index f23cf81ddb77..7f426efe40ab 100644
> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> @@ -382,7 +382,7 @@ pmu {
> interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> };
>
> - psci {
> + psci: psci {
> compatible = "arm,psci-1.0";
> method = "smc";
>
>
> ---
> base-commit: 9d0d467c3572e93c5faa2e5906a8bbcd70b24efd
> change-id: 20260407-glymur_reboot_mode-4441770e6a8a
> prerequisite-message-id: <20260427-arm-psci-system_reset2-vendor-reboots-v21-0-dcf937775e73@oss.qualcomm.com>
As far as I can tell from the discussion, that's not settled yet.
Not sure what you want me to do with this patch then...
Regards,
Bjorn
> prerequisite-patch-id: 70829f19896a982ef4ac19fa82bf571b9eb6defa
> prerequisite-patch-id: 600337ba5717c51204c4f426acb28bd6287e56ec
> prerequisite-patch-id: e7a6e85c94e35b71c9813c322e811a270233c854
> prerequisite-patch-id: 7bb3e4b151f32129e8ce5d3c1015150cbd741d13
> prerequisite-patch-id: a61561c5070b9485399a840ff48252842393f01a
> prerequisite-patch-id: c7f5c86cf5f88c6d5dd576565bcce25ee3848b19
> prerequisite-patch-id: e4d851cd0a6dfb96d62e4c9d3ebfa1422b9571a6
> prerequisite-patch-id: e6ffbbec586e6c4b508bd366615e33928a910190
> prerequisite-patch-id: 8ae267aee51f48992d2232f18dc5795b08fd8e54
> prerequisite-patch-id: 10b585e49a96767c3324c9e3c623a4716a641fda
> prerequisite-patch-id: 5abbfae8b6577899e0423b36b4690adf1046cac2
> prerequisite-patch-id: edb89ac23b7a3d5ade9b9cc1e1a77ee4d1a663cf
> prerequisite-patch-id: 555f1b64be3631d6286f2f1e140dc38c6935d646
>
> Best regards,
> --
> Pankaj Patil <pankaj.patil@oss.qualcomm.com>
>
prev parent reply other threads:[~2026-05-10 3:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 13:37 [PATCH] arm64: dts: qcom: glymur: Add psci reboot-mode edl Pankaj Patil
2026-05-10 3:28 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af_49utiHCPDlbEd@baldur \
--to=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.patil@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox