From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jingyi Wang <quic_jingyw@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Xin Liu <quic_liuxin@quicinc.com>
Subject: Re: [PATCH v2] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc
Date: Mon, 16 Sep 2024 16:57:55 +0200 [thread overview]
Message-ID: <afa070b7-7aae-49ee-a983-24bda96bd6ec@kernel.org> (raw)
In-Reply-To: <20240911-qcs8300_remoteproc_binding-v2-1-01921b110532@quicinc.com>
On 11/09/2024 08:41, Jingyi Wang wrote:
> + - items:
> + - enum:
> + - qcom,qcs8300-adsp-pas
> + - const: qcom,sa8775p-adsp-pas
> + - items:
> + - enum:
> + - qcom,qcs8300-cdsp-pas
> + - const: qcom,sa8775p-cdsp0-pas
> + - items:
> + - enum:
> + - qcom,qcs8300-gpdsp-pas
> + - const: qcom,sa8775p-gpdsp0-pas
> + - enum:
> + - qcom,sa8775p-adsp-pas
> + - qcom,sa8775p-cdsp0-pas
> + - qcom,sa8775p-cdsp1-pas
> + - qcom,sa8775p-gpdsp0-pas
> + - qcom,sa8775p-gpdsp1-pas
>
> reg:
> maxItems: 1
> @@ -64,6 +77,7 @@ allOf:
> properties:
> compatible:
Instead add here "contains:" and no need for mentioning compatible
second time. Same in other places.
Best regards,
Krzysztof
> enum:
> + - qcom,qcs8300-adsp-pas
> - qcom,sa8775p-adsp-pas
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-16 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 6:41 [PATCH v2] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc Jingyi Wang
2024-09-16 14:57 ` Krzysztof Kozlowski [this message]
2024-09-25 3:17 ` Jingyi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afa070b7-7aae-49ee-a983-24bda96bd6ec@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_jingyw@quicinc.com \
--cc=quic_liuxin@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).