Re: [PATCH 1/2] dt-bindings: iio: temperature: add support for EMC1812

[<Marius.Cristea@microchip.com>]

Hi David,

  Thank you for the feedback,

On Wed, 2025-09-17 at 18:34 -0500, David Lechner wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On 9/17/25 7:21 AM, Marius Cristea wrote:
> > This is the devicetree schema for Microchip EMC1812/13/14/15/33
> > Multichannel Low-Voltage Remote Diode Sensor Family.
> > 
> > Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
> > ---
> >  .../iio/temperature/microchip,emc1812.yaml         | 223
> > +++++++++++++++++++++
> >  MAINTAINERS                                        |   6 +
> >  2 files changed, 229 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/iio/temperature/microchip,emc18
> > 12.yaml
> > b/Documentation/devicetree/bindings/iio/temperature/microchip,emc18
> > 12.yaml
> > new file mode 100644
> > index
> > 0000000000000000000000000000000000000000..898d6d246746e229cb004f447
> > 872ee6bd5a65074
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/iio/temperature/microchip,emc18
> > 12.yaml
> > @@ -0,0 +1,223 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > http://devicetree.org/schemas/iio/temperature/microchip,emc1812.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Microchip EMC1812/13/14/15/33 multichannel temperature
> > sensor
> > +
> > +maintainers:
> > +  - Marius Cristea <marius.cristea@microchip.com>
> > +
> > +description: |
> > +  The Microchip EMC1812/13/14/15/33 is a high-accuracy 2-wire
> > multichannel
> > +  low-voltage remote diode temperature monitor.
> > +
> > +  The datasheet can be found here:
> > +   
> > https://ww1.microchip.com/downloads/aemDocuments/documents/MSLD/ProductDocuments/DataSheets/EMC1812-3-4-5-33-Data-Sheet-DS20005751.pdf
> 
> The pinouts of these chips look nearly identical to MCP998X.
> Would it make sense to share a single bindings document for these?
> Or maybe there would be too many if: blocks and keeping it separate
> is fine.
> 
> https://lore.kernel.org/linux-iio/20250829143447.18893-2-victor.duicu@microchip.com/
> 
> 

I know that the chip looks nearly identical with MCP998X, but being two
different family of devices and having different functions inside, I
would like to keep the binding separate, otherwise there will be too
many conditions.


Thanks,
Marius