From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Cong Yang <yangcong5@huaqin.corp-partner.google.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, dmitry.torokhov@gmail.com, jikos@kernel.org,
benjamin.tissoires@redhat.com, dianders@chromium.org,
hsinyi@google.com
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: input: touchscreen: Add ilitek 9882T touchscreen chip
Date: Fri, 2 Jun 2023 16:19:14 +0200 [thread overview]
Message-ID: <afd610cf-954f-afc2-00da-86da9fe4192d@linaro.org> (raw)
In-Reply-To: <20230602140948.2138668-2-yangcong5@huaqin.corp-partner.google.com>
On 02/06/2023 16:09, Cong Yang wrote:
> Add an ilitek touch screen chip ili9882t.
>
> Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
There is no way this would work and if you test you will see error msg.
Feel free to ping if message is unclear.
> ---
> .../bindings/input/elan,ekth6915.yaml | 36 ++++++++++++++-----
> 1 file changed, 27 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
> index 05e6f2df604c..73e94cb6c4e0 100644
> --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
> +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
> @@ -15,11 +15,15 @@ description:
>
> properties:
> compatible:
> - items:
> - - const: elan,ekth6915
> + oneOf:
It's not oneOf. Just enum
> + - enum:
> + - elan,ekth6915
> + - ilitek,ili9882t
>
> reg:
> - const: 0x10
> + enum:
> + - 0x10
> + - 0x41
>
> interrupts:
> maxItems: 1
> @@ -29,17 +33,31 @@ properties:
>
> vcc33-supply:
> description: The 3.3V supply to the touchscreen.
> + If using ili9882t then this supply will not be needed.
Are you sure these are compatible devices then? What does it mean "not
needed"? Is the pin there or is not?
>
> vccio-supply:
> description:
> The IO supply to the touchscreen. Need not be specified if this is the
> same as the 3.3V supply.
> -
> -required:
> - - compatible
> - - reg
> - - interrupts
> - - vcc33-supply
> + If using ili9882t, the IO supply is required.
> +
> + required:
NAK. Really. Test patches before sending.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-02 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 14:09 [PATCH 0/2] Add ili9882t timing Cong Yang
2023-06-02 14:09 ` [PATCH 1/2] dt-bindings: input: touchscreen: Add ilitek 9882T touchscreen chip Cong Yang
2023-06-02 14:19 ` Krzysztof Kozlowski [this message]
2023-06-05 6:03 ` cong yang
2023-06-02 15:14 ` Rob Herring
2023-06-02 14:09 ` [PATCH 2/2] HID: i2c-hid: elan: Add ili9882t timing Cong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afd610cf-954f-afc2-00da-86da9fe4192d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=benjamin.tissoires@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hsinyi@google.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox