* [PATCH] arm64: dts: qcom: sc7280: add display port audio
@ 2022-12-21 7:17 Judy Hsiao
2022-12-21 8:12 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Judy Hsiao @ 2022-12-21 7:17 UTC (permalink / raw)
To: Andy Gross, Douglas Anderson, Matthias Kaehlcke
Cc: linux-arm-msm, Rob Herring, linux-kernel, devicetree,
Bjorn Andersson, Judy Hsiao, Bjorn Andersson, Konrad Dybcio,
Krzysztof Kozlowski
Add DisplayPort sound node and lpass_cpu node
in sc7280-herobrine-audio-rt5682.dtsi.
Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
--
---
.../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
index af685bc35e10..69e7aa7b2f6c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
@@ -33,9 +33,22 @@ codec {
};
dai-link@1 {
- link-name = "ALC5682";
+ link-name = "DisplayPort";
reg = <1>;
+ cpu {
+ sound-dai = <&lpass_cpu LPASS_DP_RX>;
+ };
+
+ codec {
+ sound-dai = <&mdss_dp>;
+ };
+ };
+
+ dai-link@2 {
+ link-name = "ALC5682";
+ reg = <2>;
+
cpu {
sound-dai = <&lpass_cpu MI2S_PRIMARY>;
};
@@ -92,6 +105,10 @@ dai-link@1 {
reg = <MI2S_SECONDARY>;
qcom,playback-sd-lines = <0>;
};
+
+ dai-link@5 {
+ reg = <LPASS_DP_RX>;
+ };
};
/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
--
2.39.0.314.g84b9a713c41-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: add display port audio
2022-12-21 7:17 [PATCH] arm64: dts: qcom: sc7280: add display port audio Judy Hsiao
@ 2022-12-21 8:12 ` Krzysztof Kozlowski
2023-01-13 1:24 ` Judy Hsiao
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-21 8:12 UTC (permalink / raw)
To: Judy Hsiao, Andy Gross, Douglas Anderson, Matthias Kaehlcke
Cc: linux-arm-msm, Rob Herring, linux-kernel, devicetree,
Bjorn Andersson, Bjorn Andersson, Konrad Dybcio,
Krzysztof Kozlowski
On 21/12/2022 08:17, Judy Hsiao wrote:
> Add DisplayPort sound node and lpass_cpu node
> in sc7280-herobrine-audio-rt5682.dtsi.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
>
> --
> ---
That's not a correct patch format. Apply it, git show and you will see
the error.
>
> .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> index af685bc35e10..69e7aa7b2f6c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -33,9 +33,22 @@ codec {
> };
>
> dai-link@1 {
> - link-name = "ALC5682";
> + link-name = "DisplayPort";
Why do you change link@1 from DP to ALC?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: add display port audio
2022-12-21 8:12 ` Krzysztof Kozlowski
@ 2023-01-13 1:24 ` Judy Hsiao
2023-01-13 7:43 ` Krzysztof Kozlowski
2023-01-13 8:11 ` Dmitry Baryshkov
0 siblings, 2 replies; 5+ messages in thread
From: Judy Hsiao @ 2023-01-13 1:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Douglas Anderson, Matthias Kaehlcke, linux-arm-msm,
Rob Herring, linux-kernel, devicetree, Bjorn Andersson,
Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski
> Why do you change link@1 from DP to ALC?
Because I want make the order to be consistent with the 3 mic version. Thanks!
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: add display port audio
2023-01-13 1:24 ` Judy Hsiao
@ 2023-01-13 7:43 ` Krzysztof Kozlowski
2023-01-13 8:11 ` Dmitry Baryshkov
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-13 7:43 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Douglas Anderson, Matthias Kaehlcke, linux-arm-msm,
Rob Herring, linux-kernel, devicetree, Bjorn Andersson,
Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski
On 13/01/2023 02:24, Judy Hsiao wrote:
>> Why do you change link@1 from DP to ALC?
> Because I want make the order to be consistent with the 3 mic version. Thanks!
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi
You cut entire context. I don't know what is this about.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: add display port audio
2023-01-13 1:24 ` Judy Hsiao
2023-01-13 7:43 ` Krzysztof Kozlowski
@ 2023-01-13 8:11 ` Dmitry Baryshkov
1 sibling, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2023-01-13 8:11 UTC (permalink / raw)
To: Judy Hsiao, Krzysztof Kozlowski
Cc: Andy Gross, Douglas Anderson, Matthias Kaehlcke, linux-arm-msm,
Rob Herring, linux-kernel, devicetree, Bjorn Andersson,
Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski
On 13/01/2023 03:24, Judy Hsiao wrote:
>> Why do you change link@1 from DP to ALC?
> Because I want make the order to be consistent with the 3 mic version. Thanks!
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi
This should be explained in the commit message. And as Krzysztof wrote,
it should be explained, rather than mentioning some other platform.
>>
>> Best regards,
>> Krzysztof
>>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-13 8:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-21 7:17 [PATCH] arm64: dts: qcom: sc7280: add display port audio Judy Hsiao
2022-12-21 8:12 ` Krzysztof Kozlowski
2023-01-13 1:24 ` Judy Hsiao
2023-01-13 7:43 ` Krzysztof Kozlowski
2023-01-13 8:11 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).