Re: [PATCH v4 06/15] ASoC: qdsp6: q6dsp-lpass-ports: add internal mi2s support

Krzysztof Kozlowski
2026-05-03T12:12:40Z

On Fri, May 01, 2026 at 11:31:19AM -0400, Richard Acayan wrote:
> Add the internal MI2S stream capabilities as specified by the audio
> kernel modules and configure the ports as MI2S ports.
>
> Link: https://android.googlesource.com/kernel/msm-extra/+/530cffa4cc977a348753831b163eb9d3302b954a/asoc/msm-dai-q6-v2.c#4597
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> sound/soc/qcom/common.h | 2 +-
> sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c | 200 +++++++++++++++++++++++
> 2 files changed, 201 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/common.h b/sound/soc/qcom/common.h
> index ee6662885593..be693b53a4fa 100644
> --- a/sound/soc/qcom/common.h
> +++ b/sound/soc/qcom/common.h
> @@ -7,7 +7,7 @@
> #include <dt-bindings/sound/qcom,q6afe.h>
> #include <sound/soc.h>
>
> -#define LPASS_MAX_PORT (SENARY_MI2S_TX + 1)
> +#define LPASS_MAX_PORT (INT6_MI2S_TX + 1)
>
> int qcom_snd_parse_of(struct snd_soc_card *card);
> int qcom_snd_wcd_jack_setup(struct snd_soc_pcm_runtime *rtd,
> diff --git a/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c b/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> index e5cd82f77b55..7006071f45a0 100644
> --- a/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> +++ b/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> @@ -668,6 +668,205 @@ static struct snd_soc_dai_driver q6dsp_audio_fe_dais[] = {
> Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_5),
> Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_6),
> Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_7),
> + {
> + .playback = {
> + .stream_name = "INT0 MI2S Playback",

Same comments which you completely ignored.

Best regards,
Krzysztof