Re: [PATCH v4 11/15] ASoC: qcom: sm8250: add support for INT0_MI2S_RX and INT3_MI2S_TX

Mark Brown
2026-05-02T23:30:06Z

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

On Fri, May 01, 2026 at 11:31:24AM -0400, Richard Acayan wrote:

> The INT0_MI2S_RX and INT3_MI2S_TX ports on SDM660 can be connected to
> the digital and analog WCD codecs. They can be supported with the same
> logic for other ports, but just need to be explicitly stated. Add
> support for these ports.

> + case INT0_MI2S_RX:
> + codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
> + snd_soc_dai_set_sysclk(cpu_dai,
> + Q6AFE_LPASS_CLK_ID_INT0_MI2S_IBIT,
> + MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> + snd_soc_dai_set_fmt(cpu_dai, fmt);
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + break;
> + case INT3_MI2S_TX:
> + codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
> + snd_soc_dai_set_sysclk(cpu_dai,
> + Q6AFE_LPASS_CLK_ID_INT3_MI2S_IBIT,
> + MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);

Should these both be using SNDRV_PCM_STREAM_PLAYBACK?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]