From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE1AE3955DC for ; Thu, 21 May 2026 14:18:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373093; cv=none; b=U1gsEJPt80abbRJd9f/j4RZpav3cAn6EQTRMAqsAcU45qnnsLtfiFQalgMP+HBiZ6D/wmLDzSUlyx5vsk2lOXR+X6mcGaC35ze025yhsMmm652bAzNnz8lJKqINmEbZ6in6AXegEh3cx0PxqyUEeCsgP/mnygAblf8Sx+8azXX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373093; c=relaxed/simple; bh=HAfl/SaeMd4fujRbesGuMrdvcRLCdqxksnWMjbIPy1A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i4vhjAn+kLJ2FYXiS9IQS4pQYrU2F6QNtPhOscrFaA+30HOslaPpELhCldBrOS0sv/gCjeN3i26zVe6jZBI6wUjV8o3Kb1GdgvHK+SabfkhcLhDhbJR1QD2GUKV/OFDaifYids3AjbskxLR9YQxVJ+B0QXuu+1elUYu6r0OVeSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wQ4Dj-0007o0-Qt; Thu, 21 May 2026 16:17:55 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wQ4Di-0017O6-30; Thu, 21 May 2026 16:17:55 +0200 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wQ4Dj-00000004Wuk-1aW2; Thu, 21 May 2026 16:17:55 +0200 Date: Thu, 21 May 2026 16:17:55 +0200 From: Michael Tretter To: Sven =?utf-8?Q?P=C3=BCschel?= Cc: Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de, Nicolas Dufresne Subject: Re: [PATCH v7 13/28] media: rockchip: rga: calculate x_div/y_div using v4l2_format_info Message-ID: Mail-Followup-To: Michael Tretter , Sven =?utf-8?Q?P=C3=BCschel?= , Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de, Nicolas Dufresne References: <20260521-spu-rga3-v7-0-3f33e8c7145f@pengutronix.de> <20260521-spu-rga3-v7-13-3f33e8c7145f@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260521-spu-rga3-v7-13-3f33e8c7145f@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org On Thu, 21 May 2026 00:44:18 +0200, Sven Püschel wrote: > Calculate the x_div and y_div variables with the information from > v4l2_format_info instead of storing these in the rga_fmt struct. > > Reviewed-by: Nicolas Dufresne > Signed-off-by: Sven Püschel Reviewed-by: Michael Tretter > --- > drivers/media/platform/rockchip/rga/rga-hw.c | 45 +++++++--------------------- > drivers/media/platform/rockchip/rga/rga.h | 2 -- > 2 files changed, 11 insertions(+), 36 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rga/rga-hw.c b/drivers/media/platform/rockchip/rga/rga-hw.c > index 40498796507e0..17f7a67c0b4bb 100644 > --- a/drivers/media/platform/rockchip/rga/rga-hw.c > +++ b/drivers/media/platform/rockchip/rga/rga-hw.c > @@ -42,6 +42,7 @@ rga_get_addr_offset(struct rga_frame *frm, struct rga_addr_offset *offset, > { > struct rga_corners_addr_offset offsets; > struct rga_addr_offset *lt, *lb, *rt, *rb; > + const struct v4l2_format_info *format_info; > unsigned int x_div = 0, > y_div = 0, uv_stride = 0, pixel_width = 0; > > @@ -50,8 +51,16 @@ rga_get_addr_offset(struct rga_frame *frm, struct rga_addr_offset *offset, > rt = &offsets.right_top; > rb = &offsets.right_bottom; > > - x_div = frm->fmt->x_div; > - y_div = frm->fmt->y_div; > + format_info = v4l2_format_info(frm->pix.pixelformat); > + /* x_div is only used for the u/v planes. > + * When the format doesn't have these, use 1 to avoid a division by zero. > + */ > + if (format_info->bpp[1]) > + x_div = format_info->hdiv * format_info->bpp_div[1] / > + format_info->bpp[1]; > + else > + x_div = 1; > + y_div = format_info->vdiv; > uv_stride = frm->stride / x_div; > pixel_width = frm->stride / frm->pix.width; > > @@ -476,128 +485,96 @@ static struct rga_fmt formats[] = { > .color_swap = RGA_COLOR_ALPHA_SWAP, > .hw_format = RGA_COLOR_FMT_ABGR8888, > .depth = 32, > - .y_div = 1, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_ABGR32, > .color_swap = RGA_COLOR_RB_SWAP, > .hw_format = RGA_COLOR_FMT_ABGR8888, > .depth = 32, > - .y_div = 1, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_XBGR32, > .color_swap = RGA_COLOR_RB_SWAP, > .hw_format = RGA_COLOR_FMT_XBGR8888, > .depth = 32, > - .y_div = 1, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_RGB24, > .color_swap = RGA_COLOR_NONE_SWAP, > .hw_format = RGA_COLOR_FMT_RGB888, > .depth = 24, > - .y_div = 1, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_BGR24, > .color_swap = RGA_COLOR_RB_SWAP, > .hw_format = RGA_COLOR_FMT_RGB888, > .depth = 24, > - .y_div = 1, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_ARGB444, > .color_swap = RGA_COLOR_RB_SWAP, > .hw_format = RGA_COLOR_FMT_ABGR4444, > .depth = 16, > - .y_div = 1, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_ARGB555, > .color_swap = RGA_COLOR_RB_SWAP, > .hw_format = RGA_COLOR_FMT_ABGR1555, > .depth = 16, > - .y_div = 1, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_RGB565, > .color_swap = RGA_COLOR_RB_SWAP, > .hw_format = RGA_COLOR_FMT_BGR565, > .depth = 16, > - .y_div = 1, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_NV21, > .color_swap = RGA_COLOR_UV_SWAP, > .hw_format = RGA_COLOR_FMT_YUV420SP, > .depth = 12, > - .y_div = 2, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_NV61, > .color_swap = RGA_COLOR_UV_SWAP, > .hw_format = RGA_COLOR_FMT_YUV422SP, > .depth = 16, > - .y_div = 1, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_NV12, > .color_swap = RGA_COLOR_NONE_SWAP, > .hw_format = RGA_COLOR_FMT_YUV420SP, > .depth = 12, > - .y_div = 2, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_NV12M, > .color_swap = RGA_COLOR_NONE_SWAP, > .hw_format = RGA_COLOR_FMT_YUV420SP, > .depth = 12, > - .y_div = 2, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_NV16, > .color_swap = RGA_COLOR_NONE_SWAP, > .hw_format = RGA_COLOR_FMT_YUV422SP, > .depth = 16, > - .y_div = 1, > - .x_div = 1, > }, > { > .fourcc = V4L2_PIX_FMT_YUV420, > .color_swap = RGA_COLOR_NONE_SWAP, > .hw_format = RGA_COLOR_FMT_YUV420P, > .depth = 12, > - .y_div = 2, > - .x_div = 2, > }, > { > .fourcc = V4L2_PIX_FMT_YUV422P, > .color_swap = RGA_COLOR_NONE_SWAP, > .hw_format = RGA_COLOR_FMT_YUV422P, > .depth = 16, > - .y_div = 1, > - .x_div = 2, > }, > { > .fourcc = V4L2_PIX_FMT_YVU420, > .color_swap = RGA_COLOR_UV_SWAP, > .hw_format = RGA_COLOR_FMT_YUV420P, > .depth = 12, > - .y_div = 2, > - .x_div = 2, > }, > }; > > diff --git a/drivers/media/platform/rockchip/rga/rga.h b/drivers/media/platform/rockchip/rga/rga.h > index 640e510285341..27b3c9b4f220c 100644 > --- a/drivers/media/platform/rockchip/rga/rga.h > +++ b/drivers/media/platform/rockchip/rga/rga.h > @@ -20,8 +20,6 @@ > struct rga_fmt { > u32 fourcc; > int depth; > - u8 y_div; > - u8 x_div; > u8 color_swap; > u8 hw_format; > }; > > -- > 2.54.0 > > -- Pengutronix e.K. | Michael Tretter | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |