From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B03FB3EDE62 for ; Thu, 21 May 2026 14:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373740; cv=none; b=J+Zen5zDekmR58Z7lFHtadjl1rslIad6wwG8tSh9KuiOLa+vd/8eBxXVNiso/955m5gDvnRMbQ2uej74a12vKV4jfeB4X9FOO2cbSfpfTZin9MOQUKrMS7Y/QOm5h8gyLMv+sHLaDkPw2jJqgzw9n/vFOiz3Kb0eAjkPyCQIRQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373740; c=relaxed/simple; bh=ICgwgs59ODqm6QeFKToTOkDZMhdRWIdveuu7IHHozAI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kf8y9f/g8+He3Kybjtm5pcHrCaODNGmCd034h15R/yMMQHuqdLLa3ieGvgI7SvDAwiTTgILqzYOaCa6iTXt7C0f1N9Fd3dDUZTpV+m739I9mm7d4dSacrkbYqRP9v714DATe5cC4d4Nw0o2U5eDgCYjPF7WNdNgBBa/8vl29FKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wQ4OC-0000xx-9s; Thu, 21 May 2026 16:28:44 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wQ4OB-0017PQ-0r; Thu, 21 May 2026 16:28:43 +0200 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wQ4OB-00000004X5s-2zV1; Thu, 21 May 2026 16:28:43 +0200 Date: Thu, 21 May 2026 16:28:43 +0200 From: Michael Tretter To: Sven =?utf-8?Q?P=C3=BCschel?= Cc: Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de, Nicolas Dufresne Subject: Re: [PATCH v7 18/28] media: rockchip: rga: use card type to specify rga type Message-ID: Mail-Followup-To: Michael Tretter , Sven =?utf-8?Q?P=C3=BCschel?= , Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de, Nicolas Dufresne References: <20260521-spu-rga3-v7-0-3f33e8c7145f@pengutronix.de> <20260521-spu-rga3-v7-18-3f33e8c7145f@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260521-spu-rga3-v7-18-3f33e8c7145f@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org On Thu, 21 May 2026 00:44:23 +0200, Sven Püschel wrote: > In preparation of the RGA3 support add a filed to the rga_hw struct *field > to specify the desired card type value. This allows the user to > differentiate the RGA2 and RGA3 video device nodes. > > Reviewed-by: Nicolas Dufresne > Signed-off-by: Sven Püschel > --- > drivers/media/platform/rockchip/rga/rga-hw.c | 1 + > drivers/media/platform/rockchip/rga/rga.c | 4 +++- > drivers/media/platform/rockchip/rga/rga.h | 1 + > 3 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rockchip/rga/rga-hw.c b/drivers/media/platform/rockchip/rga/rga-hw.c > index f2900812ba76f..43fd023b7571c 100644 > --- a/drivers/media/platform/rockchip/rga/rga-hw.c > +++ b/drivers/media/platform/rockchip/rga/rga-hw.c > @@ -577,6 +577,7 @@ static struct rga_fmt formats[] = { > }; > > const struct rga_hw rga2_hw = { > + .card_type = "rga2", This changes the card type from "rockchip-rga" to "rga2", which is a user space visible change and may break user space. Is this acceptable or even intentional? Michael > .formats = formats, > .num_formats = ARRAY_SIZE(formats), > .cmdbuf_size = RGA_CMDBUF_SIZE, > diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c > index 22954bbae55fc..91775b43ff617 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -354,8 +354,10 @@ static const struct v4l2_file_operations rga_fops = { > static int > vidioc_querycap(struct file *file, void *priv, struct v4l2_capability *cap) > { > + struct rockchip_rga *rga = video_drvdata(file); > + > strscpy(cap->driver, RGA_NAME, sizeof(cap->driver)); > - strscpy(cap->card, "rockchip-rga", sizeof(cap->card)); > + strscpy(cap->card, rga->hw->card_type, sizeof(cap->card)); > strscpy(cap->bus_info, "platform:rga", sizeof(cap->bus_info)); > > return 0; > diff --git a/drivers/media/platform/rockchip/rga/rga.h b/drivers/media/platform/rockchip/rga/rga.h > index df525c6aea8b6..cee2e75ea89f1 100644 > --- a/drivers/media/platform/rockchip/rga/rga.h > +++ b/drivers/media/platform/rockchip/rga/rga.h > @@ -149,6 +149,7 @@ static inline void rga_mod(struct rockchip_rga *rga, u32 reg, u32 val, u32 mask) > }; > > struct rga_hw { > + const char *card_type; > struct rga_fmt *formats; > u32 num_formats; > size_t cmdbuf_size; > > -- > 2.54.0 > >