From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC16E47AF67; Tue, 12 May 2026 08:12:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778573567; cv=none; b=gBAfQBxiBtzIydHhBVe6OG3R3fzEV5if7T0F6znSY2UvOIm6Os19vkTArksPKP78tRJ41QjiUJahMEkETlaQndzchp5v56NNRioZRcvZevonWQHRioAmrNYIUZAA4Jl1fn6KKgTbp/6yQzSYXZmLG5PFS+pCtCRMQZrMxkdfEBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778573567; c=relaxed/simple; bh=iKoZSxz8wlSZlrKHB8el8X5w1WWSeeWHYoI1BzyYxx4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oQRTsBS90RwkzaWM9w66AmEAgK3qVOtMs/BKVkVxytD2NIoyyAXIy8ToXB3DBVCZcRECwum1nJj6dByJ4Gm4ttzoN/rVHQx3Sv58YgoAe9baHUdTifYhdHcpIPf5SOBN/iJ8Iqozz3IGpreKp9pSJRNiuzI8V15V0fXvrDKJoDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eeMjzPH6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eeMjzPH6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A291C2BCB0; Tue, 12 May 2026 08:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778573566; bh=iKoZSxz8wlSZlrKHB8el8X5w1WWSeeWHYoI1BzyYxx4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eeMjzPH6Y/sUarT1XK6P0RpXt2R5PQui6P34ZNR8P61RgTyLW+wx+fF0hLkYfHGek 0i7+BKOZLYbYnc2Ia1YBYQgZ9oyxi5zfhhtybCJN6qK2egaD0RQ/WE7mnKj6g3y7xq K/nNZjnHnsvLgH4uktUqbKKXHDpExs0QgdynJ7SnZJDH5eEbMJ3XNJv4UjbRq8szNt joos0Nz/JUfqsu0Gefb2y26gQa2500/LCDc2r7MFKERI8aV81gRF34tJEcsXtb6NlN iZf3gDCIOslXPYGu61cO+yjgfLLiFwya56pmodtdFhtMvlx9jUlZM/51eclhgFrVV5 tg9/16MhBQTSA== Date: Tue, 12 May 2026 13:42:42 +0530 From: Vinod Koul To: Caleb James DeLisle Cc: linux-phy@lists.infradead.org, naseefkm@gmail.com, neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-mips@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] phy: econet: Add PCIe PHY driver for EcoNet EN751221 and EN7528 SoCs. Message-ID: References: <20260404184918.2184070-1-cjd@cjdns.fr> <20260404184918.2184070-3-cjd@cjdns.fr> <23a04af8-beec-417d-8d3f-9d587bffe953@cjdns.fr> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23a04af8-beec-417d-8d3f-9d587bffe953@cjdns.fr> On 10-05-26, 13:25, Caleb James DeLisle wrote: > > On 10/05/2026 13:16, Vinod Koul wrote: > > On 04-04-26, 18:49, Caleb James DeLisle wrote: > > > + val = field_prep(data[i].mask, data[i].val); > > Please see: > > > > https://sashiko.dev/#/patchset/20260425173642.406089-1-cjd%40cjdns.fr > > > I think this is an error in that the AI is not correctly differentiating > between field_prep() which accepts a non-constant mask, and FIELD_PREP() > which does not. In any case I can confirm that it does compile and work > correctly on the device. Right AI might be confusing FIELD_PREP with field_prep()! I will review the series now > > On another note, I think you may be the creator of Sashiko, if so, thank you > for your work - it helped me with another patch already. Oh no, I cant claim credit. It is not me -- ~Vinod