From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E89763B8D4A; Wed, 13 May 2026 20:10:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778703040; cv=none; b=QlhTVguwN42R2OV9Qt5bDys3Uz8wju3qVt2J5BDppdfb5AX77TEhxA8vHaDplkNApo+t7X/YC2LU2F6FtsSVPGSEml5hW0vrTSlNi1Wwjlx7Ql7Ly2gtcOpnezqaLCw5PLn0X8/Jah9rDfIWEnsOEpDWyeYLmhcqBYgMBmi6dQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778703040; c=relaxed/simple; bh=+q1v693MAGcslpV1s79s1V0yzFFNOoetpgIGymEEQmw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a2yWtPeeAchMWnjFHcun0VjQbWo3muBusgNA6RX7TOOhIXhF6BMyS03URS/ost9RHnH1Ju9xazVstk8VbFrl4Wosdo8/c90h6IbEXXOhtPMndovs8Wg3+/xemUYHWK+ySRVIPhEUkxH98Qa/Sl9oA41qqZH/XwI0A5bgo9+m28I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GdH+nYMX; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GdH+nYMX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778703039; x=1810239039; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+q1v693MAGcslpV1s79s1V0yzFFNOoetpgIGymEEQmw=; b=GdH+nYMXtvz2Y+U0cvJIDzWbjcsO8CDeH0omNjsmZRv5z8nCItvUWpUr aBrb0cPppk4qnTK4XpGe+qJqO/ggR++FoBnvvJ3m9vvdVp0FNcGDbwXje 3pAGulVb2roH/CF2sxoWRkZHsgQHuyqIMu8Q2oPirtpouGBSZZytv2dTu Ny67XVuOVdxv3AMwJEohgrP8uHL/Hp4WFCwAGBCnXY6d8CV3/pKgmFpLq hFva2pTrOczrqcUFZDJYvwaH/t04yMTZ7kJb4syuJ5EEjoTgPibkOLsA/ n1CWEKraaNOwaPMXdGlJjcPoKGyL4OjgWZ95b3+I9lhTx8nRvNnPjlE3S g==; X-CSE-ConnectionGUID: zZEWSZVeR5OWyuTsluYO0g== X-CSE-MsgGUID: ioiArEXARSuUG+bkyp0r3A== X-IronPort-AV: E=McAfee;i="6800,10657,11785"; a="78783753" X-IronPort-AV: E=Sophos;i="6.23,233,1770624000"; d="scan'208";a="78783753" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 13:10:38 -0700 X-CSE-ConnectionGUID: hqPYoZtcREGRjllT8qq3pQ== X-CSE-MsgGUID: TvHpd68SS9OV9CIROPU+RQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,233,1770624000"; d="scan'208";a="237317710" Received: from slindbla-desk.ger.corp.intel.com (HELO localhost) ([10.245.244.106]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 13:10:34 -0700 Date: Wed, 13 May 2026 23:10:31 +0300 From: Andy Shevchenko To: Michal Piekos Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maksim Kiselev , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] iio: adc: sun20i-gpadc: add A523 gpadc support Message-ID: References: <20260513-sunxi-a523-gpadc-v2-0-d5efde151dac@mmpsystems.pl> <20260513-sunxi-a523-gpadc-v2-2-d5efde151dac@mmpsystems.pl> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513-sunxi-a523-gpadc-v2-2-d5efde151dac@mmpsystems.pl> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, May 13, 2026 at 06:59:43AM +0200, Michal Piekos wrote: > A523 differs from existing sun20i-gpadc-iio by having two clocks; bus > clock and module clock. > > Change driver to enable all clocks. ... > struct iio_dev *indio_dev; > struct sun20i_gpadc_iio *info; > struct reset_control *rst; > - struct clk *clk; > + struct clk_bulk_data *clks; Try to follow reversed xmas tree order. > int irq; > int ret; ... > - return dev_err_probe(dev, PTR_ERR(clk), "failed to enable bus clock\n"); > + ret = devm_clk_bulk_get_all_enabled(dev, &clks); > + if (ret <= 0) > + return dev_err_probe( > + dev, ret, > + "failed to enable clocks or no clocks defined\n"); Is this done by clang-format or so? Please, don't do wrapping on the open parenthesis. Also note for more than 10 years checkpatch does not complain on the trailing string literals that go over 80 characters. -- With Best Regards, Andy Shevchenko