Devicetree
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Alexey Charkov <alchark@flipper.net>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	David Lin <CTLIN0@nuvoton.com>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: codecs: nau8822: add support for supply regulators
Date: Thu, 14 May 2026 10:43:07 +0900	[thread overview]
Message-ID: <agUoq2N_nE_Sz0Z_@sirena.co.uk> (raw)
In-Reply-To: <20260513-nau8822-reg-v1-2-c532e18e92ad@flipper.net>

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

On Wed, May 13, 2026 at 05:39:11PM +0400, Alexey Charkov wrote:

> +	for (i = 0; i < ARRAY_SIZE(regulators); i++) {
> +		ret = devm_regulator_get_enable_optional(dev, regulators[i]);
> +		if (ret && ret != -ENODEV)
> +			return dev_err_probe(dev, ret,
> +					     "Failed to get regulator %s\n",
> +					     regulators[i]);
> +	}

As ever unless the device can work with the supply being physically
absent regulators should never be optional.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-05-14  1:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 13:39 [PATCH 0/2] ASoC: nau8822: add support for supply regulators Alexey Charkov
2026-05-13 13:39 ` [PATCH 1/2] ASoC: dt-bindings: nau8822: Add " Alexey Charkov
2026-05-13 13:39 ` [PATCH 2/2] ASoC: codecs: nau8822: add support for " Alexey Charkov
2026-05-14  1:43   ` Mark Brown [this message]
2026-05-14  5:39   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agUoq2N_nE_Sz0Z_@sirena.co.uk \
    --to=broonie@kernel.org \
    --cc=CTLIN0@nuvoton.com \
    --cc=alchark@flipper.net \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox