From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Vladislav Kulikov <vlad.kulikov.c@gmail.com>
Cc: jic23@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] iio: magnetometer: add driver for MEMSIC MMC5983MA
Date: Sun, 17 May 2026 09:21:37 +0300 [thread overview]
Message-ID: <aglecY6YjWccJTza@ashevche-desk.local> (raw)
In-Reply-To: <20260511191135.36691-3-vlad.kulikov.c@gmail.com>
On Mon, May 11, 2026 at 07:11:35PM +0000, Vladislav Kulikov wrote:
> Add support for the MEMSIC MMC5983MA 3-axis magnetometer. The driver
> provides raw magnetic field readings via IIO sysfs with SET/RESET
> offset cancellation for each measurement.
Good driver, something to improve, though. Jonathan, can you tweak these in
tree? But perhaps wait a bit for the answer on "why no cache?".
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
+ arrray_size.h
> +#include <linux/bits.h>
> +#include <linux/cleanup.h>
> +#include <linux/delay.h>
+ dev_printk.h
+ err.h
> +#include <linux/i2c.h>
> +#include <linux/iio/iio.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/regmap.h>
> +#include <linux/time.h>
> +#include <linux/types.h>
...
> +static const struct regmap_config mmc5983_regmap_config = {
> + .name = "mmc5983_regmap",
> + .reg_bits = 8,
> + .val_bits = 8,
> + .max_register = MMC5983_REG_ID,
> + .writeable_reg = mmc5983_is_writeable_reg,
> + .readable_reg = mmc5983_is_readable_reg,
> + .volatile_reg = mmc5983_is_volatile_reg,
> +};
Why no cache?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-17 6:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 19:11 [PATCH v3 0/2] iio: magnetometer: add MEMSIC MMC5983MA driver Vladislav Kulikov
2026-05-11 19:11 ` [PATCH v3 1/2] dt-bindings: iio: magnetometer: add MEMSIC MMC5983MA Vladislav Kulikov
2026-05-11 19:11 ` [PATCH v3 2/2] iio: magnetometer: add driver for " Vladislav Kulikov
2026-05-17 6:21 ` Andy Shevchenko [this message]
2026-05-17 11:34 ` Jonathan Cameron
2026-05-16 11:40 ` [PATCH v3 0/2] iio: magnetometer: add MEMSIC MMC5983MA driver Jonathan Cameron
2026-05-16 14:14 ` Vlad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aglecY6YjWccJTza@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=vlad.kulikov.c@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox