From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: marius.cristea@microchip.com
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, broonie@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] add support for Microchip PAC194X Power Monitor
Date: Sun, 17 May 2026 10:04:24 +0300 [thread overview]
Message-ID: <agloeEkyzR65lB12@ashevche-desk.local> (raw)
In-Reply-To: <20260515092946.10791-1-marius.cristea@microchip.com>
On Fri, May 15, 2026 at 12:29:44PM +0300, marius.cristea@microchip.com wrote:
> Add support for Microchip PAC194X and PAC195X series of Power Monitor
> with Accumulator chip family. This driver covers the following part
> numbers:
> - PAC1941, PAC1941-2, PAC1942, PAC1942-2, PAC1943, PAC1944
> - PAC1951, PAC1951-2, PAC1952, PAC1952-2, PAC1953, PAC1954
>
> The PAC194X family supports 9V Full-Scale Range and the PAC195X supports
> 32V Full-Scale Range.
>
> There are two versions of the PAC194X/5X: the PAC194X-1/5X-1 devices are
> for high-side current sensing and the PAC194X/5X-2 devices are for low-side
> current sensing or floating VBUS applications. The PAC194X/5X-1 is named
> shortly PAC194X/5X.
It still has many subtle issues...
I am not able to review in a couple of weeks, so I recommend to read mailing lists
for the previous reviews against other big driver submissions and improve yours
accordingly.
So far, on a very fast glance I have noticed:
- the IWYU principle is not being followed
- the Kconfig help text can be improved to list part numbers for better
maintainability
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-17 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 9:29 [PATCH v4 0/2] add support for Microchip PAC194X Power Monitor marius.cristea
2026-05-15 9:29 ` [PATCH v4 1/2] dt-bindings: iio: adc: add support for PAC1944 marius.cristea
2026-05-15 9:38 ` sashiko-bot
2026-05-15 17:24 ` Conor Dooley
2026-05-15 17:29 ` Conor Dooley
2026-05-15 9:29 ` [PATCH v4 2/2] iio: adc: add support for PAC194X marius.cristea
2026-05-15 10:06 ` sashiko-bot
2026-05-16 16:40 ` David Lechner
2026-05-16 18:21 ` Jonathan Cameron
2026-05-16 16:36 ` [PATCH v4 0/2] add support for Microchip PAC194X Power Monitor David Lechner
2026-05-17 7:04 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agloeEkyzR65lB12@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.cristea@microchip.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox