From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70175330D36 for ; Mon, 18 May 2026 11:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779105100; cv=none; b=TOkkIoqcDg7TcGRCN2cD9nNOZiLxWTNg9hWx7/TwxBS5eOOm6/8S78v64I6/1PRiv35Dl3lAVROwP7eiZRntX1hYopePst5Z52VYk1INO3wERi9wj9ZGBWGeJKOHTREUSDLloI4IB+0NU8f1/RaHV4jO+6N5VlwUS1Eisksb1vE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779105100; c=relaxed/simple; bh=5Z9hPhqS8oaSLq86Bc3gD4M5ws/BmUkz38QLBtVDsSY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uQnLI7LFqtizbwH6hjxo+6jJrjQP6Cx8TCDwhO6zfc9gRwrjzIK4uyyv1XH64xrdLMStAJEfcr6rjoiGVDA8bw8+3TknKmHIo5otNRtxKwL+fqUkRYzHE0nNC73SUhuVkkb0/uoI/TP1mW65U0sa9wvOE1haOYQVbx35oEuHKGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ErLR2sQv; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ErLR2sQv" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4891b4934ffso1265e9.0 for ; Mon, 18 May 2026 04:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779105097; x=1779709897; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2tqNcSw5901z0ZWyLeYPwIMccpM8CGNBD8cgagm4vKA=; b=ErLR2sQvRD2NAz/YAzulim9c+ASR9AgNK2vh1u/IvqSQ6WgS+qPAU1airk0xybcGLX VX6Wc3kFl2C7L+HMULZ+KLr8h9NWAlbCyw2B1lWehuFsIYjHNQDUyQx9IZE/Wt9i3bvK sXcZhRkviz20F39odlDSgwliVQClZ9ArOIJnmynIgoJPCY3IrsxuesZYXxH49Yl83GHI oP5tesLZxVuMFr9hIYfnDEDhGbVlWS7wiRsFnO6kSbgs9n+/wPo/pXCxPa076C4i0ix4 e96XG4S+1ael2JnkxV2Ltfp0JZToU/WnYPAtmrCP5/+Iwwg12U8JaFL9JMmSbdTajj4P DWRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779105097; x=1779709897; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2tqNcSw5901z0ZWyLeYPwIMccpM8CGNBD8cgagm4vKA=; b=A9ebK1Y2sIrJL5zfE5C0iLi0GhQwIZufVZrcf9KUYKcqCRHWQLr1nvgvWaBas0kOgZ vXp+WYTGibtIKiuLMGnB+mswyZ1iYiW2m0q0LkfZIJqhCi7nD93d/cfx/GDHUPBGwj2C y05xfDittWTULuVD3VJlKV1/Cbg1+qqsamVaSQAW/V1f1lmwB/9uuHkJMpoBdztxi+7V gPp5e6S4CuTxycrpKtFfHwBR2JZYQ/G1zpLPiddCqoj5q9uId+Q28sObZGjucWXnIcYa juB8R9SDb/9WmUM//5jr5YhbQ4lt2GPECITGH4LoR6fWPfZXTKohwaLORxyUcRqWOely 8RiA== X-Forwarded-Encrypted: i=1; AFNElJ81zUiPe9tg4KEql+gcV3t8HMDpgAjVb/iKoEjwqVR1zsymclo0XiRs2A2jTcJKSmf0BXHnNi2udqnK@vger.kernel.org X-Gm-Message-State: AOJu0Yw47C5KPKzkRChu1qGB37yVkEomfO6q4M6F3LMDCsAcXze8RkN3 T8S1cMRMtbPCDFmBo/D9H3udlTeQGWJPn/FQHmFVi9bEpitOJqRvwCXcvkcdUGdWpg== X-Gm-Gg: Acq92OGY6iyLR4Ehuj8P88nuKe88g+mna7WT6IxPLqCmHcSU1pFJ+qli1JBBNYm+txN bSHcr8AVUK5AxGdIWTHINoT0h+vX6LC8cxT/oCjy0O+bU+RCUxjZ+1sRLlXe1S+eYWDg4USGLiN n7saIvJfWJgk+6VSvFpymkXHGfoktMheEWoNJ8ZLSSEA821A8ocOjVjISoBkKRLjRU5pIcc+8U+ h2MDliBy1XPbJ2AtraiQBxJ3m5nyGb3bYvo9Fk13sOSLq/ybuNb8zcuy6LMzBcmfC2kWN9asFZE C4DF17AipFFWEFrmF6P3LVNwweN3M7GaKtlglYaWS7MHsPGTk4kD+uC0box+KEMXywfujkFVGgu JKBg8VChzPRkqCkTQvhc3zhf+AtEXiDbbu9HS0vS3HQoDsZFCIB0YiboMXnbB0fFcQdbYUyaoeo lxjV9qSkAUNp4yAIvP7qj7TDyAmEweCsLRwIihmvOJ4vrTln5Yn/wqwOK97Z5Aft5qUZo= X-Received: by 2002:a05:600c:5650:b0:48a:5aa3:ac1e with SMTP id 5b1f17b1804b1-48ffd828c95mr1864315e9.3.1779105096335; Mon, 18 May 2026 04:51:36 -0700 (PDT) Received: from google.com (8.181.38.34.bc.googleusercontent.com. [34.38.181.8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48ffed68baesm59218185e9.0.2026.05.18.04.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 04:51:35 -0700 (PDT) Date: Mon, 18 May 2026 11:51:31 +0000 From: Mostafa Saleh To: Konrad Dybcio Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org Subject: Re: Support for Lenovo IdeaCentre Mini X (Purwa) Message-ID: References: <20260429141815.827157-1-smostafa@google.com> <5c838838-00e5-45f2-9515-edbdcddf50ec@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, May 15, 2026 at 01:28:00PM +0200, Konrad Dybcio wrote: > On 4/30/26 7:22 PM, Mostafa Saleh wrote: > > Hi Konrad, > > > > On Thu, Apr 30, 2026 at 06:48:33PM +0200, Konrad Dybcio wrote: > >> On 4/29/26 4:18 PM, Mostafa Saleh wrote: > >>> Hi, > >>> > >>> I see that recently the support for “Lenovo IdeaCentre Mini X” was > >>> added [1] > >>> However, unfortunately that doesn’t work for my device, the board > >>> resets once I try to boot the kernel from UEFI. > >>> > >>> I believe that’s because it is another variant, as I have been using > >>> my device tree for some time[2] which is hacked based on the crd > >>> device tree with some trial and error. With that I can boot with > >>> PCI/NVME/Ethernet and USB (there are also some other errors in the > >>> log related PMIC), this device tree is based on purwa.dtsi unlike > >>> the upstream one which use hamoa.dtsi. > >>> > >>> Are there any plans to support the Purwa based variant? I am happy to > >>> help with testing, but I can’t confidently send patches as my device > >>> tree is based on trial and error rather than a data sheet. > > [...] > > > I can try to see the differences and build another dt on top of the > > hamoa one, but that will also be based on trial and error rather than > > actual knowledge, I am happy to test patches if you have other > > suggestions. > > Hm, I ran a quick diff and even though there's a lot of noise (mostly > due to the same things being named slightly differently), the actual > meat and potatoes aren't very different at all, e.g. the PHY regulators > are the same > > Could you post the full dmesg with both DTs? This is the log with the device tree that boots[1]: https://gist.github.com/misaleh/b09c04480062c5a3e7bafe3d4176b15d This is the log with replacing hamoa.dtsi with purwa.dtsi inside hamoa-lenovo-ideacentre-mini-01q8x10.dtsi which does not boot: https://gist.github.com/misaleh/aaad5704824edac9a43e2ebe45adbf85 With those modifications, I can boot: diff --git a/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts b/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts index bfb7cea56df9..00f9a1d5ac95 100644 --- a/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts +++ b/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts @@ -8,7 +8,7 @@ #include #include -#include "hamoa.dtsi" +#include "purwa.dtsi" #include "hamoa-pmics.dtsi" / { @@ -17,7 +17,7 @@ / { chassis-type = "desktop"; aliases { - serial0 = &uart14; + serial0 = &uart21; }; wcd938x: audio-codec { @@ -185,6 +185,7 @@ vreg_nvme2_3p3: regulator-nvme2-3p3 { pinctrl-names = "default"; regulator-boot-on; + status = "disabled"; }; vreg_v0p9: regulator-v0p9 { @@ -714,19 +715,20 @@ &pcie3 { vddpe-3v3-supply = <&vreg_nvme2_3p3>; - status = "okay"; + status = "disabled"; }; &pcie3_phy { vdda-phy-supply = <&vreg_l3c>; vdda-pll-supply = <&vreg_l3e>; - status = "okay"; + status = "disabled"; }; &pcie3_port0 { reset-gpios = <&tlmm 143 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 145 GPIO_ACTIVE_LOW>; + status = "disabled"; }; &pcie4 { @@ -1064,21 +1066,9 @@ wcn_sw_en: wcn-sw-en-state { }; }; -&uart14 { +&uart21 { + compatible = "qcom,geni-debug-uart"; status = "okay"; - - bluetooth { - compatible = "qcom,wcn7850-bt"; - max-speed = <3200000>; - - vddaon-supply = <&vreg_pmu_aon_0p59>; - vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; - vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; - vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; - vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; - vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; - vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>; - }; }; &usb_1_ss0 { The issues were: - pcie6a and pcie3 conflict in regulator pins - Different UART However, there are quite verbose errors from MDSS clocks, and spmi failures. Here are the booting logs with the above change (at loglevel=5) https://gist.github.com/misaleh/3b1d67ac51a8960b811cc20075ab7630 I get cleaner boot logs with MDSS and pmc8380_6 disabled. [1] https://github.com/misaleh/linux/blob/lenovo/arch/arm64/boot/dts/qcom/x1p42100-lenovo-ideacentre-x-gen10.dts Thanks, Mostafa > > Konrad