From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE9D48AE02 for ; Mon, 18 May 2026 15:53:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779119624; cv=none; b=eHFKgp4K6pEGsgHzgsOLmfUF0PWa+1ssjr8pqxrn+8EpwS4G5wWwB+bOH69xnUZ1URciM1EnwTA8GO/+ZYCbFczKEI0lSOptDUZJLW+h/bjkYwRa0Ll/0TxDM/BvoT64wXMXMkErnwcCSZWtsSpJCGPmZF5jdnEna7Zvyiw5468= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779119624; c=relaxed/simple; bh=S6SVBqmcAvHY5nTiiDj99x5B0CqWbX8RSys9dvTwzVk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Oh9Gg2MBOQCqLGRH2tQnlEVMpVi+EdH79QF8KZd+w5wzm9QYLMREKp2OWCyng/mbsHzs8B9EMP22SLmJLILRWV432fXMJYYgn004S/7p2mvaPILCcsLM4dHMFd3n/SgAtHAQcZrWWejVSwe5We0lqkw05zgL36QyOprKBzFbdBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gEIL5JDj; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=tgzJw+j2; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gEIL5JDj"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="tgzJw+j2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779119609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wZCyUkEWRjyv2fKKDGGvW1Vl+jU51oCsDzDIRpAen0g=; b=gEIL5JDjDLezKWWHvXVMOTwyG3cMwTt7md6pTQ3mKuqmJL15glXW8CTliw3R65uOwHHtQm Yic1IuoWNdukIKy278tj/01LmcueP7feNKgH3/mdOHUxPneWdeM0U0h69a/sotYmJKJj3c z10B0lUP410QNxTkAjw44UF8CIxeE70= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-hukbde0_Nb6dXf57yklepg-1; Mon, 18 May 2026 11:53:28 -0400 X-MC-Unique: hukbde0_Nb6dXf57yklepg-1 X-Mimecast-MFC-AGG-ID: hukbde0_Nb6dXf57yklepg_1779119608 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8baa173eacbso39897436d6.0 for ; Mon, 18 May 2026 08:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779119608; x=1779724408; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=wZCyUkEWRjyv2fKKDGGvW1Vl+jU51oCsDzDIRpAen0g=; b=tgzJw+j2vhZNqmMa3hG500Ea43o4/yQMZlOHrwfG6AEthEPZRsLiP8xp3s2EbpM7O2 1L2jqMfsC7LeCWMfE0gekaQdqnBPjdzx0pCZtYFOM9qvdbbRPPB8qFe1WHZuY66VZV2y UlcfuuDAPsj0+84QLv2U3m5wcm8XhMFmGnf2nLVlO1msMhFXuI1c2F0rJR8JSIRz+UCp iJ+lkW41M+nwLAcw89pzD7x0RZkWH5nAhduKDCwmSOdQasxNlbblmaoFdXp2e1wWWXRw F3jeP2RZC8WRoWHBUIXxmzdQNvmoNgGboNvlVnXALoKRUfd0ghyzJt040F/czwDKCgc6 z0ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779119608; x=1779724408; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wZCyUkEWRjyv2fKKDGGvW1Vl+jU51oCsDzDIRpAen0g=; b=eHlgqcfoeRlZQb968X4b8oOIckB0vPRmNVfcwh6tU8WWy/BmFWT4KwKXB9TGMPAscH 8rvR/6W59NuN00elNBpU+/IFboC3if/VJKgWaOF9SdViXAqfQ/WhAPrp1ZmcgAiXXGOV 8uE28kMj/afnM8rxJXnStRZWOBrIhE85DTRPjr0q5xUHMJk7Te8WOoTAU8iV+6HzflhT C5+3HPcpsWn3yS+wjh6qhZIA3WBe9RP43dkqSRZfC11mpYgROqCMPclSffxBNBg1UTt3 nYUQpiJt/drOSlF9Hd0NXxmK34uYhUYQZpW/zGhAWK6tKKpN6t+FP1NYnkBGKJ43Ro9E G+rw== X-Forwarded-Encrypted: i=1; AFNElJ9agRzYndVPqvqt+K/p3Ao+LGvRSZG52nYL3CcaM31thVHqJBYOR2hR93XGmBimYgAxNOTOkNMADP3K@vger.kernel.org X-Gm-Message-State: AOJu0Yx08mu6rJxBfjdm1YNFewOWOF3Q4MDrmdggseQi/jQEkCKb/2ck MSBZCfRg8Csy0Q7VVZmhyEyLE2/gazTWn/LhxM17w09SwA/sr8sscsmWnd2b5fdkLVheVs7u5jk efFR8m/o1p5cq8YDLK42e65diQv9v+WilkNvmv2tC7CxGCh9it6a/IKaUMcfoj8M= X-Gm-Gg: Acq92OFauhO2ge4UERmhocCMZR2QtySR9TqgtNyvsSoLim1QTc5GoRbqmE+ybePs2sd jVxWjaXlq6MZhT1u2UlwEPZQxQZD03OJj79ryw3s2W1PbxghYOV4NHlU8kR5iFzU9YAbV28i17l hug1NJSIgpf4S5vxDYLjglwPQ1RFZv7hK04G4Td8QCFnb91XEt5J+4fRDgv/cUN2vWDvjNhz5cZ qhMBr5am9JQfHTmNEYpqtYF1gR3Rv0RORvRZjs+MljwHJCJpfNm/rPEXHK780Adi6ThAazYVMmZ owvi1EDFWpoh5hTVNTX5bm7K6SDJtrCC2LoYh9A1Bwo2GoKmP+aALxvHqZlSmrAnLqb9B+PySY0 7gT+uTYNCLAbp1irMolLKFbBQ1iL7IW+vD/IGvbPqHTlV/RBIPy642Aba X-Received: by 2002:a05:620a:4006:b0:8c9:fb69:e708 with SMTP id af79cd13be357-911cc6aeac9mr2295179985a.25.1779119607759; Mon, 18 May 2026 08:53:27 -0700 (PDT) X-Received: by 2002:a05:620a:4006:b0:8c9:fb69:e708 with SMTP id af79cd13be357-911cc6aeac9mr2295176185a.25.1779119607260; Mon, 18 May 2026 08:53:27 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910baf2236fsm1529569185a.20.2026.05.18.08.53.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 08:53:26 -0700 (PDT) Date: Mon, 18 May 2026 11:53:24 -0400 From: Brian Masney To: Junhui Liu Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Troy Mitchell Subject: Re: [PATCH v5 1/6] clk: correct clk_div_mask() return value for width == 32 Message-ID: References: <20260514-dr1v90-cru-v5-0-34f3021aab51@pigmoral.tech> <20260514-dr1v90-cru-v5-1-34f3021aab51@pigmoral.tech> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260514-dr1v90-cru-v5-1-34f3021aab51@pigmoral.tech> User-Agent: Mutt/2.3.1 (2026-03-20) On Thu, May 14, 2026 at 05:27:17PM +0800, Junhui Liu wrote: > The macro clk_div_mask() currently wraps to zero when width is 32 due to > 1 << 32 being undefined behavior. This leads to incorrect mask generation > and prevents correct retrieval of register field values for 32-bit-wide > dividers. > > Although it is unlikely to exhaust all U32_MAX div, some clock IPs may rely > on a 32-bit val entry in their div_table to match a div, so providing a > full 32-bit mask is necessary. > > Fix this by using the standard GENMASK() macro. This safely resolves the > undefined behavior on both 32-bit and 64-bit architectures, while also > benefiting from the built-in compile-time type and bounds checking > provided by the GENMASK() macro. > > Cc: Troy Mitchell > Cc: Brian Masney > Signed-off-by: Junhui Liu Reviewed-by: Brian Masney