From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099803F0744; Tue, 19 May 2026 14:06:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779199563; cv=none; b=S3IZ5JmX4Gn+umgcTU5OFA0diVddLov16l9VkNrstY66ECLlQ3qruq2kF1E0q5KpfKvHgonvkLaNt3dhk/mz9jkkn6IPTQu50X3CzSDXmnuMX1PZ5krdwklq+ou4TWWt9PGG4J8rJhXnHrV2gt/5cNEVaab81eJNSnDF9fMmYOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779199563; c=relaxed/simple; bh=lBSEGo7O8hgJ9dLZNCapesRoomudLa7YDbyuKR0GaYs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ml/X9zdIN5H/BU9WxYttr2LoMRYZ43XXAI1SQWBozxZO9nkoNgDKcRfMy/IFnIoPv4x76nZW8OT/XcZneZ6NOSSuNeqDhTWu6MudrfqAkJAKCahebkoJIalB+v1H9V9yqbkDt8z2NIWcKFGsXc3egGINjxOZOcHiv7VaNU0N/A8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lj7Zv1LA; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lj7Zv1LA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1779199561; x=1810735561; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lBSEGo7O8hgJ9dLZNCapesRoomudLa7YDbyuKR0GaYs=; b=lj7Zv1LAfZJeiikSv/y7I8mTuGLD6vv8kcl8Ur1LqvBqGKCPDcyxnB5U oBeUNl3BA+Mo4rlC/1nEm8bIoXW0Ly2XYnoiE7F+iXgrQcLSYC7IFpcEa RjadOAIjFYB4ii68Ybm6QmgViHt9/frNumdshlkZ4DIkAWPc89KSBoyhK /iat3Pokhu7j+RDyiduWpnmLaXp8F2kWjs/KmcFYT9Ky8wXOHhO3UYGeI gkoCx0ED7qbJW/xqgj3bwQ6eIMgyRDIqyhMLpSFZwwW0QoevKPArBsI7h xTYuP+29Q1pT2YLkZSFrXQHVcdc0uET94qZjIhL9+OsJp1bMu83tOUbaz w==; X-CSE-ConnectionGUID: 0Im4ecPuT3C3zRQYOgvfkA== X-CSE-MsgGUID: HGy9XJTYSuKkMYIhfFwTZg== X-IronPort-AV: E=McAfee;i="6800,10657,11791"; a="82642876" X-IronPort-AV: E=Sophos;i="6.23,243,1770624000"; d="scan'208";a="82642876" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2026 07:05:59 -0700 X-CSE-ConnectionGUID: 6ljnlqZOSJiEhUFOsE2rnQ== X-CSE-MsgGUID: cJGSqS8wSkC57oQu8xOI1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,243,1770624000"; d="scan'208";a="244745243" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa005.jf.intel.com with ESMTP; 19 May 2026 07:05:56 -0700 Received: by black.igk.intel.com (Postfix, from userid 1008) id 29F5D95; Tue, 19 May 2026 16:05:55 +0200 (CEST) Date: Tue, 19 May 2026 17:05:43 +0300 From: Heikki Krogerus To: Dmitry Baryshkov Cc: Bryan O'Donoghue , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] usb: typec: tcpm: qcom: prefer VBUS supply from the connector node Message-ID: References: <20260519-fix-tcpm-vbus-v1-0-14754695282d@oss.qualcomm.com> <20260519-fix-tcpm-vbus-v1-2-14754695282d@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260519-fix-tcpm-vbus-v1-2-14754695282d@oss.qualcomm.com> On Tue, May 19, 2026 at 01:48:04PM +0300, Dmitry Baryshkov wrote: > Current way of specifying VBUS supply (via the device's vdd-vbus-supply > property) is not ideal. In the end, VBUS is supplied to the USB-C > connector rather than the Type-C block in the PMIC. Follow the standard > way of specifying it (via the connector node) and fallback to the old > property if there is no vbus-supply in the connector node. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > index 8051eaa46991..429bd42a0e62 100644 > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -704,6 +705,7 @@ int qcom_pmic_typec_port_probe(struct platform_device *pdev, > struct device *dev = &pdev->dev; > struct pmic_typec_port_irq_data *irq_data; > struct pmic_typec_port *pmic_typec_port; > + struct fwnode_handle *connector; > int i, ret, irq; > > pmic_typec_port = devm_kzalloc(dev, sizeof(*pmic_typec_port), GFP_KERNEL); > @@ -720,7 +722,15 @@ int qcom_pmic_typec_port_probe(struct platform_device *pdev, > > mutex_init(&pmic_typec_port->vbus_lock); > > - pmic_typec_port->vdd_vbus = devm_regulator_get(dev, "vdd-vbus"); > + connector = device_get_named_child_node(dev, "connector"); > + if (!connector) > + return -EINVAL; > + > + pmic_typec_port->vdd_vbus = devm_of_regulator_get_optional(dev, > + to_of_node(connector), > + "vbus"); > + if (pmic_typec_port->vdd_vbus == ERR_PTR(-ENODEV)) > + pmic_typec_port->vdd_vbus = devm_regulator_get(dev, "vdd-vbus"); > if (IS_ERR(pmic_typec_port->vdd_vbus)) > return PTR_ERR(pmic_typec_port->vdd_vbus); > > > -- > 2.47.3 -- heikki