From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35B102248A8; Tue, 2 Jun 2026 11:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780398479; cv=none; b=eFov4wTzc2+mmEHVIhmDWhZJDK5BSIvDydgXqTDgycSbmKCDY7ZqFIDt+O0a0KukfNuYyIoDrxRLBbTcAc/8e/Tpc7q6e+ZhgJXTcO290gctgx469J4TALMknESQ8f7KKD5ZXeAbdUrLRu3FtKyfJWwry/XslfO5DGvbwoVPceg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780398479; c=relaxed/simple; bh=mFctebV6efZPkxdiXhNEx0eARojG2bev1G/ivejaxqo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N5wKO8m96znIGQ/0XMMQP7T7KO+4pogBlQAeP5k+mz0MgyGHLW62+e7/BevmT3b6NTZhXvXkPY+qlXwjfeHAzUUayzDZT7hwZN0w1uedJGVW5ZPDutvrDsVaJc6j/Wvi6gTJegP2sFnvBpO2iDfbVYyzXg2VxOIHjnKpa8Y8m8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nmoBBVOr; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nmoBBVOr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780398478; x=1811934478; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=mFctebV6efZPkxdiXhNEx0eARojG2bev1G/ivejaxqo=; b=nmoBBVOrwCFnArKyPsbRh2FzPl9jwRcZOXoLNpFrFLjddrEvZmlZfG/v /QXsOWkVLe8NH9Xs6+JLb7cBlw62RvEmm/OciI4i6wvzdCW4v1MU4Cd2w YS6vTxn1ep4t898jFGxkMebeSof0l3zILA6pY2Yb/h1jjYcdlzApxrM6P PSbQzaAarTyQM9wH+nnTCHqtngFD/zXzqh5iYspCTfrLUFc3DHt//x5nx DjlZFl7x6LbKi+LrQELFP+ramY9+p67RIHmH12PZrFLhUVQ41qyGDxOru hWhOA7BN45MXBZgLaNM0cFAJsXbixOLJdXSV4NzEOZinf73HOS96Wx3Pt g==; X-CSE-ConnectionGUID: I7V0s52lSaCsHjS5TnTuVg== X-CSE-MsgGUID: bT+99yrZQBGd+OXYk9skhQ== X-IronPort-AV: E=McAfee;i="6800,10657,11804"; a="81207825" X-IronPort-AV: E=Sophos;i="6.24,183,1774335600"; d="scan'208";a="81207825" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2026 04:07:57 -0700 X-CSE-ConnectionGUID: lhiRJlaQQHmUbKHn1VV+4A== X-CSE-MsgGUID: r7XmoXFkTjavabE0tmKG2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,183,1774335600"; d="scan'208";a="243975444" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.229]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2026 04:07:52 -0700 Date: Tue, 2 Jun 2026 14:07:49 +0300 From: Andy Shevchenko To: Svyatoslav Ryhel Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Helge Deller , Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 08/11] video: backlight: lm3533_bl: Improve linear sysfs logic Message-ID: References: <20260601151831.76350-1-clamor95@gmail.com> <20260601151831.76350-9-clamor95@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Jun 02, 2026 at 01:19:00PM +0300, Svyatoslav Ryhel wrote: > вт, 2 черв. 2026 р. о 11:09 Andy Shevchenko пише: > > On Mon, Jun 01, 2026 at 06:18:28PM +0300, Svyatoslav Ryhel wrote: ... > > > if (kstrtoul(buf, 0, &linear)) > > > return -EINVAL; > > > > Besides _assign_bits() in the below, side note here to unshadow error codes: > > > > ret = kstrtoul(buf, 0, &linear); > > if (ret) > > return ret; > > > > (obviously in a separate change). > > Won't happen in this patches. You mean both suggestions or you are talking about kstrotoul() only? If it's only about the latter, it's fine with me, but _assign_bits() makes sense to do in this patch as you already change the parameters enough to make it better. ... > > > ret = regmap_update_bits(bl->lm3533->regmap, LM3533_REG_CTRLBANK_AB_BCONF, > > > - mask, val); > > > + CTRLBANK_AB_BCONF_MODE(id), > > > + linear ? CTRLBANK_AB_BCONF_MODE(id) : 0); > > > if (ret) > > > return ret; ^^^ left for the context. -- With Best Regards, Andy Shevchenko